Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symbiflow-vtr-optimized with PGO enabled #143

Closed
wants to merge 1 commit into from
Closed

Add symbiflow-vtr-optimized with PGO enabled #143

wants to merge 1 commit into from

Conversation

HackerFoo
Copy link

@HackerFoo HackerFoo commented Nov 10, 2020

This builds VPR, and then collects profile data, and uses that to compile VPR again with profile-guided optimization.

@HackerFoo HackerFoo marked this pull request as ready for review November 13, 2020 12:34
(
curl $SYMBIFLOW_INSTALL_URL | tar xJ -C symbiflow
) &
FETCH_SYMBIFLOW_PID=$!
Copy link
Author

@HackerFoo HackerFoo Nov 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This task runs in parallel with the first build, so that downloading and unpacking the SymbiFlow install package doesn't take any additional time.

Copy link

@litghost litghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The eblif should be either sourced from another repo, or compressed.

Copy link

@litghost litghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments in

Signed-off-by: Dusty DeWeese <dustin.deweese@gmail.com>
@HackerFoo
Copy link
Author

The eblif should be either sourced from another repo, or compressed.

The eblif is compressed now (180KB).

@HackerFoo
Copy link
Author

The symbiflow-vtr-optimized package builds successfully with conda build on my machine.

@HackerFoo
Copy link
Author

I've added an issue to update this after verilog-to-routing/vtr-verilog-to-routing#1564 is merged: #155

Copy link

@litghost litghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple things.

stdout is too long. Consider piping to a file and greping for error/warnings, etc? Or just redirect to a file and output something when an error occurs?

CI is red:

The job exceeded the maximum time limit for jobs, and has been terminated.

This may be because of the stdout length?

@mithro
Copy link
Member

mithro commented Dec 2, 2020

The job exceeded the maximum time limit for jobs, and has been terminated.

GitHub Actions has significantly more powerful hardware and a much longer timeout, so I think we might want to wait until after that is landed so we can take advantage of that?

@HackerFoo
Copy link
Author

HackerFoo commented Dec 14, 2020

This PR is superseded by hdl/conda-eda#60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants