Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yosys cannot infer BRAM correctly on current master+wip #17

Closed
mkurc-ant opened this issue Mar 12, 2019 · 5 comments
Closed

Yosys cannot infer BRAM correctly on current master+wip #17

mkurc-ant opened this issue Mar 12, 2019 · 5 comments

Comments

@mkurc-ant
Copy link

Yosys on current master+wip (SHA: 22eaab1) cannot infer BRAM (or any memory) when given a verilog array with a series of initial statements.

I've checked that the last correctly working commit is 98104b3.

In order to reporoduce:

  1. Clone the Yosys repo (master+wip branch)
  2. Build it
  3. Set env. variable YOSYS to point to the Yosys binaty
  4. Clode the symbiflow-arch-defs repo (master 2e7d736) and run make env
  5. Build EBLIF file for tests/9-soc/picosoc
  6. Check how many BRAMS are there in the synthesized design. There should be 2 instead of 1.

I don't know if it is an upstream bug or not so I am posting it here.

@mkurc-ant
Copy link
Author

This PR in YosysHQ introduced the unwanted behavior: YosysHQ#843

@mkurc-ant
Copy link
Author

Created an issue upstream: YosysHQ#867

@mkurc-ant
Copy link
Author

So the problem is now fixed on YosysHQ (f0b2d8e). @litghost Can you integrate master+wip from YosysHQ again? Or at least changes from YosysHQ#868

@litghost
Copy link

So the problem is now fixed on YosysHQ (f0b2d8e). @litghost Can you integrate master+wip from YosysHQ again? Or at least changes from YosysHQ#868

I can, but FYI you could have also made the PR.

@mkurc-ant
Copy link
Author

@litghost Ok, I've created a PR: #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants