Fixed bug in source extraction. #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rceExtractor. Issue prevents extraction of source files from symbols package.
|
I got hit by this bug! Most probably because of this pushing packages with sources does not work in SymbolSource.Server.Basic 1.3.2. Downgrading to 1.3.1 (and SymbolSource.Microsoft.Cci.Metadata to 1.0.65055.0) helps. |
…lers with the kernel.
…guration. Changes to MicroKernel to support adding custom controllers and configuration. Changes allow injecting a custom data and index path via a custom implementation of the IBasicServerConfiguration interface. Custom data and index paths require a custom Data controller to handle downloads of source and pdb files.
|
Any idea why this hasn't been merged in, and why a new copy of the package hasn't been published? Seems totally broken at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue prevents extraction of source files from symbols package.