Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

methods #43

Closed
1 task done
SymbolixAU opened this issue Jan 10, 2019 · 0 comments
Closed
1 task done

methods #43

SymbolixAU opened this issue Jan 10, 2019 · 0 comments
Labels
enhancement New feature or request
Milestone
v0.3.0

Comments

@SymbolixAU
Copy link
Collaborator

SymbolixAU commented Jan 10, 2019 •
edited by dcooley

Move method logic into C++ to account for factors and dates and stuff at source.

Design ideas

  • how do we account for different arguments for different input types (n_summaries for numeric, summary = T/F for char, etc)?
  • maybe I keep the methods based on the R object type, and just work out the palette type at src (because palette is either STRSXP or REALSXP/VECSXP)

TODO

  • track down colourvalues:::rcpp_colour_values_hex(letters[1:5], "viridis", 255, include_alpha = F, summary = T)
@SymbolixAU SymbolixAU self-assigned this Jan 10, 2019
@SymbolixAU SymbolixAU modified the milestones: v0.2.2, v0.3.0 Jan 10, 2019
@SymbolixAU SymbolixAU added the enhancement New feature or request label Feb 24, 2019
@SymbolixAU SymbolixAU mentioned this issue May 6, 2019
Closed
1 task
dcooley added a commit that referenced this issue Jun 7, 2019
@dcooley
integrating lists for #49 and #43
e91edff
@dcooley dcooley closed this as completed in 58e7a93 Jun 8, 2019
@SymbolixAU SymbolixAU removed their assignment Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.3.0
Development

No branches or pull requests
0 participants