fill_colour in add_polygon not correct when stroke_colour is not defined

[tim-salabim]

When using add_polygon and only defining fill_colour the resulting colour seems not correct (should be white).

library(mapdeck)

key = "<my_api_key>"
set_token(key)

sf <- geojsonsf::geojson_sf("https://symbolixau.github.io/data/geojson/SA2_2016_VIC.json")

map = mapdeck(
  token = key
  , style = mapdeck_style('dark')
)

## not white
map %>%
  add_polygon(
    data = sf
    , fill_colour = "#ffffffff"
  )

However, when we also define stroke_colour it renders correctly (in white)

## white
map %>%
  add_polygon(
    data = sf
    , fill_colour = "#ffffffff"
    , stroke_colour = "#000000"
  )

I realised this behaviour when testing mapview with mapdeck for add_pointcloud. Given that add_pointcloud does not have a stroke_colour argument, I haven't found a way to get the proper colour representation for add_pointcloud.

[dcooley]

ok, this is caused by the

const polygonLayer = new deck.PolygonLayer({
  ... 
  extruded: true
  ...
});

When this is set to false, the colour is as it should be.

I can make this work for non-extruded polygons from within R, but I think the colouring issue lies with deck.gl.

I'll make a reprex and post an issue on their github.

[dcooley]

It also might have to do with the lighting effects, which I haven't fully explored yet ( #174 )

mapdeck(
	, style = mapdeck_style('dark')
)  %>%
	add_polygon(
		data = sf
		, fill_colour = "#ffffffff"
		#, stroke_colour = "#ffffffff"
		, elevation = 2000
	)

[dcooley]

this commit should solve the imediate issue.

[tim-salabim]

Thanks for the quick action! From my side, this is solved.