Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] php-cs-fixer it up #283

Merged
merged 1 commit into from Feb 20, 2024
Merged

[ci] php-cs-fixer it up #283

merged 1 commit into from Feb 20, 2024

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented Feb 20, 2024 •
edited

public method signature changes are a non-factor

@jrushlow jrushlow marked this pull request as ready for review February 20, 2024 00:17
@jrushlow jrushlow added Minor Minor Enhancement Status: Needs Review Needs to be reviewed labels Feb 20, 2024
bocharsky-bw
bocharsky-bw approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again, Jesse!

@bocharsky-bw bocharsky-bw merged commit df64d82 into SymfonyCasts:main Feb 20, 2024
8 checks passed
@jrushlow jrushlow deleted the ci/php-cs-fixer branch February 20, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bocharsky-bw bocharsky-bw bocharsky-bw approved these changes

Assignees
No one assigned
Labels
Minor Minor Enhancement Status: Needs Review Needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrushlow @bocharsky-bw