Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[generator] throws ResetPasswordRuntimeException when unable to create json #309

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented Apr 16, 2024

  • createToken() now throws a ResetPasswordRuntimeException when unable to convert the $verified, $userId, and $expiresAt values to json. Previously, we did not ensure that json_encode() returned a string.

  • depends on [token] throws ResetPasswordRuntimeException #308 for the exception

@jrushlow jrushlow added the Feature New Feature label Apr 16, 2024
@jrushlow jrushlow added this to the 2.x - Pre-release milestone Apr 16, 2024
@jrushlow jrushlow changed the title [generator] throws ResetPasswordRuntimeException when unable to creae json [generator] throws ResetPasswordRuntimeException when unable to create json Apr 17, 2024
@jrushlow jrushlow force-pushed the feature/generator-exception branch from c7e9e95 to 918e694 Compare April 17, 2024 08:47
@jrushlow jrushlow force-pushed the feature/generator-exception branch from 918e694 to 75c01ef Compare April 17, 2024 08:54
@jrushlow jrushlow merged commit b15e3a1 into SymfonyCasts:2.x Apr 17, 2024
6 checks passed
@jrushlow jrushlow deleted the feature/generator-exception branch April 17, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant