removed full class name in property docblock #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrushlow
force-pushed
the
refactor/controller-trait-test
branch
from
1570382
to
17446cf
Compare
weaverryan
reviewed
Mar 27, 2020
| @@ -10,6 +10,7 @@ | |||
| namespace SymfonyCasts\Bundle\ResetPassword\Tests\FunctionalTests\Persistence; | |||
|
|
|||
| use Doctrine\Bundle\DoctrineBundle\Registry; | |||
| use Doctrine\Common\Persistence\ObjectManager; | |||
There was a problem hiding this comment.
Hmm, actually, this should use the ObjectManager from doctrine/persistence - this class is deprecated. I also see one more mention in ResetPasswordTestFixtureRequestRepository.php
|
This looks ready but tests are failing. Does it just need a rebase to get updated? |
forces deprecation warning of Doctrine\Common\.. classes
jrushlow
force-pushed
the
refactor/controller-trait-test
branch
from
c53b0c0
to
2d61dca
Compare
No, an upstream dependency changed and is now breaking the functional/integration tests. I have to dig in and see whats messing up the dir paths in our tests. |
This was referenced Apr 5, 2020
jrushlow
added a commit
to jrushlow/reset-password-bundle
that referenced
this pull request
Apr 6, 2020
originally ref'd in PR SymfonyCasts#75
|
This PR was combined with #96 and is no longer relevant. |
jrushlow
added a commit
to jrushlow/reset-password-bundle
that referenced
this pull request
Apr 6, 2020
originally ref'd in PR SymfonyCasts#75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.