Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent external deprecations from failing CI tests #87

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented Apr 1, 2020

  • silence external deprecation notices in CI
  • add CI build that is allowed to fail to catch all deprecation notices

refs #85

@jrushlow jrushlow added enhancement New feature or request CI CI releated issues labels Apr 1, 2020
@kbond
Copy link
Contributor

kbond commented Apr 1, 2020

Too bad github actions doesn't have an "allow failure" option for a workflow. At least we are still able to see the deprecation warnings in the job output.

I think as long as we are testing dev-master, we would start to see tests fail once the deprecated code is removed. Using a cron build trigger could help if there is a large amount of time between contributions.

@jrushlow
Copy link
Collaborator Author

jrushlow commented Apr 1, 2020

I have a couple ideas about how to trigger "allowed failures" from indirect deprecation notices, but those are outside the scope of this PR.

In the meantime, will merge to fix current CI and look into the above separately.

@jrushlow jrushlow merged commit 40c0618 into SymfonyCasts:master Apr 1, 2020
@jrushlow jrushlow deleted the fix/deprecations branch April 1, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI releated issues enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants