Set a default value for $isDebug in SymfonycastsSassExtension

[evertharmeling]

At the moment when you run php bin/console config:dump symfonycasts_sass it throws an exception.

In SymfonycastsSassExtension.php line 74:

Typed property Symfonycasts\SassBundle\DependencyInjection\SymfonycastsSassExtension::$isDebug must not be accessed before initialization

Setting a default value fixes this.

[bocharsky-bw]

Seems reasonable 👍

[WebMamba]

I just don't get why you have your config kernel.debug set to null? Are you using the bundle outside a Symfony App? Or do you use a custom Kernel?

[bocharsky-bw]

@WebMamba Hm, I can reproduce this issue on the Symfony Demo app, the first time I run symfony console config:dump symfonycasts_sass - it works, but the further runs it throws

Typed property Symfonycasts\SassBundle\DependencyInjection\SymfonycastsSassExtension::$isDebug must not be accessed before initialization

until I clear the cache. Then it repeats: works 1st time and does not the next times

[evertharmeling]

Yes, like bocharsky-bw describes.

However, that would probably mean that the 'real' value is lost after cache is warmed. And with the first commit resulting in $isDebug always being false...

I've updated the PR of an other approach...

[WebMamba]

Yes, good catch! Looks good to me

[bocharsky-bw]

Thanks for the fix! Good simplification :)