Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional load paths #37

Merged
merged 4 commits into from
May 22, 2024

Conversation

squrious
Copy link
Contributor

Hi there,

This is a proposal implementation for #28

@squrious
Copy link
Contributor Author

Rebased to get the fix for FunctionalTest

Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks for describing this feature in the docs!

src/SassBuilder.php Outdated Show resolved Hide resolved
src/DependencyInjection/SymfonycastsSassExtension.php Outdated Show resolved Hide resolved
src/DependencyInjection/SymfonycastsSassExtension.php Outdated Show resolved Hide resolved
src/DependencyInjection/SymfonycastsSassExtension.php Outdated Show resolved Hide resolved
doc/index.rst Outdated Show resolved Hide resolved
@tomm1996
Copy link

What has to happen in order to unblock the merge of this PR?

Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I'm not sure how we can rebuild it to see if tests pass.

doc/index.rst Outdated Show resolved Hide resolved
@squrious
Copy link
Contributor Author

This looks good to me, but I'm not sure how we can rebuild it to see if tests pass.

Hi! Is there something I can do here to help?

Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Also, I don't see any further comments on it, so I will consider it as ready.

Thank you for working on it!

@bocharsky-bw bocharsky-bw merged commit d88601c into SymfonyCasts:main May 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants