Merge pull request #17 from jrushlow/remove/get-signature-lifetime

removed helper method to get the expected lifetime of a signature

src/VerifyEmailHelper.php

@@ -79,12 +79,4 @@ public function isSignedUrlValid(string $signedUrl, string $userId, string $user
 
         return $this->uriSigner->check($signedUrl);
     }
-
-    /**
-     * {@inheritdoc}
-     */
-    public function getSignatureLifetime(): int
-    {
-        return $this->lifetime;
-    }
 }

src/VerifyEmailHelperInterface.php

@@ -28,7 +28,7 @@ interface VerifyEmailHelperInterface
      * @param string $userEmail   the email that is being verified
      * @param array  $extraParams any additional parameters (route wildcards or query parameters)
      *                            that will be used when generating the route for
-     *                            signed URL.
+     *                            signed URL
      */
     public function generateSignature(string $routeName, string $userId, string $userEmail, array $extraParams = []): VerifyEmailSignatureComponents;
 
@@ -57,9 +57,4 @@ public function generateSignature(string $routeName, string $userId, string $use
      * @throws ExpiredSignatureException
      */
     public function isSignedUrlValid(string $signedUrl, string $userId, string $userEmail): bool;
-
-    /**
-     * Get the length of time in seconds that a signed uri is valid.
-     */
-    public function getSignatureLifetime(): int;
 }

tests/UnitTests/VerifyEmailHelperTest.php

@@ -128,12 +128,6 @@ public function testExceptionThrownWithExpiredSignature(): void
         $helper->isSignedUrlValid($signature, '1234', 'jr@rushlow.dev');
     }
 
-    public function testGetLifetimeReturnsIntFromLifetimeProperty(): void
-    {
-        $helper = $this->getHelper();
-        self::assertSame(3600, $helper->getSignatureLifetime());
-    }
-
     private function getHelper(): VerifyEmailHelperInterface
     {
         return new VerifyEmailHelper($this->mockRouter, $this->mockSigner, $this->mockQueryUtility, $this->tokenGenerator, 3600);