trait for registration controller #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
reviewed
May 4, 2020
| */ | ||
| class VerifyEmailControllerTrait | ||
| { | ||
| private function isConfirmationValid(Request $request): void |
There was a problem hiding this comment.
I'd say this should return a bool
|
|
||
| if ($user->isVerified()) { | ||
| throw new \Exception('Your email address has already been verified.'); | ||
| } |
There was a problem hiding this comment.
I don't think we care about this case. The user could choose to check this already if they wanted. But if the user is already verified... and they want to verify again, go for it! Technically speaking, this has nothing to do with the signature being valid or not.
|
no longer relevant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.