Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] inject UriSigner directly in the VerifyEmailHelper #164

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented Mar 12, 2024

  • We can inject the UriSigner directly into VerifyEmailHelper instead of using a factory to pick the correct service.
  • We can remove xor deprecate the UriSignerFactory in a separate PR for 2.0 depending on what we do with [1.x] UriSigner to become internal in 2.x #165
  • replace @final docBlock tag with final class keyword in UriSignerFactory

@jrushlow jrushlow added the Feature New Feature label Mar 12, 2024
@jrushlow jrushlow added this to the 2.x - Pre-release milestone Mar 12, 2024
@jrushlow jrushlow changed the title [2.x] drop legacy uri signer [2.x] inject UriSigner directly in the VerifyEmailHelper Mar 12, 2024
@jrushlow jrushlow force-pushed the feature/2.x/force-uri-signer branch from 6022d6e to 063776b Compare March 14, 2024 08:22
@jrushlow jrushlow merged commit cd550dc into SymfonyCasts:2.x Mar 14, 2024
6 checks passed
@jrushlow jrushlow deleted the feature/2.x/force-uri-signer branch March 14, 2024 08:30
@jrushlow jrushlow mentioned this pull request Mar 18, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant