Update Travis matrix build & bump up Composer dependencies #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamil
force-pushed
the
update-constraints
branch
from
462b5b2
to
8442fd4
Compare
pamil
force-pushed
the
update-constraints
branch
from
8442fd4
to
c8e5665
Compare
| $wrongParameterValue = 'some other value'; | ||
|
|
||
| return array( | ||
| // the container does not have the parameter | ||
| array($emptyContainer, $parameterName, $parameterValue, true, false), | ||
| // the container has the parameter but the values don't match | ||
| array($containerWithParameter, $parameterName, $wrongParameterValue, true, false), | ||
| array($this->createMockContainerWithParameters(array($parameterName => $parameterValue)), $parameterName, $wrongParameterValue, true, false), |
There was a problem hiding this comment.
Mocked method was available only for the first call, I haven't used PhpUnit mocks yet so this is the best I came up with :)
There was a problem hiding this comment.
Looks reasonable to me as it doesn't make much sense to reuse the mocked object.
|
Ping @matthiasnoback 🎉 Anyway, I'm using these test libraries heavily for a while and if you're looking for someone to maintain it, just drop me a line :) |
|
It's quite a blocker, since I can't install new release of ConfigTest along with DependencyInjectionTest. |
|
Thanks, sorry for letting you wait. |
| "symfony/config": "^2.0.5|~3.0", | ||
| "sebastian/exporter": "~1" | ||
| "matthiasnoback/symfony-config-test": "^1.0|^2.0", | ||
| "phpunit/phpunit": "^4.0|^5.0", |
There was a problem hiding this comment.
This has nothing to do here and was especially removed on #47.
@matthiasnoback Could you please revert this back?
greg0ire
added a commit
to greg0ire/SymfonyDependencyInjectionTest
that referenced
this pull request
Oct 19, 2016
It was sneakily moved back to require in SymfonyTest#61, without any explanation. Also see SymfonyTest#47, SymfonyTest#28.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to SymfonyTest/SymfonyConfigTest#32 - drops unsupported Symfony versions and PhpUnit
3.7. Moreover, drops support for SymfonyConfigTest0.*and allows for2.0to be installed.