Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make AppKernel with KernelTestCase compatible #44
feat: Make AppKernel with KernelTestCase compatible #44
Changes from 9 commits
49b1de0
bf8507a
db7a1ff
c4afea5
8ff35b8
0c13b2e
424499c
2826783
a77203f
f5dab95
ecbc67e
1c997e3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new feature you snuck in. Why is it better to have an array of values rather than calling the underlying methods?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄 Yeah.
I liked the idea of the options in the
KernelTestCase
, you are right, the methods are better.The reason why I introduced this is: You only have the possibility to change the config by override the
createKernel
this limits it to a configuration per file and not per test. (If you don't want to boot it yourself and just want to usestatic:bootKernel
.)By just call the
handleOptions
in thecreateKernel
you can actually passthrough everything before the kernel is booted and the container is compiled.Another Idea, that just came in my mind, we could just create a option like
config
which must be a callable:Then we can benefit from the methods and save some lines, cause the
KernelTestCase
makes the booting process.This file was deleted.