Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iGEM 2018 Distribution collection #652

Closed
jamesscottbrown opened this issue Jul 27, 2018 · 19 comments
Closed

iGEM 2018 Distribution collection #652

jamesscottbrown opened this issue Jul 27, 2018 · 19 comments
Assignees
Milestone

Comments

@jamesscottbrown
Copy link
Contributor

SynBioHub currently has a collection containing the parts from the iGEM 2017 Distribution.

Are you planning to import the parts from the 2018 Distribution? This could be useful to students doing iGEM this year.

@jamesscottbrown jamesscottbrown changed the title iGEM 2018 Collection iGEM 2018 Distribution collection Jul 27, 2018
@cjmyers
Copy link
Collaborator

cjmyers commented Jul 29, 2018

Sure. I can create this. Is there any reason to keep the 2017 distribution at this point? This is just a Collection that links to the iGEM records, so I don't think anyone would be referencing this collection. If I keep the old one, it might be confusing, since the Members of Other Collections will include both the 2017 and 2018 distributions.

@cjmyers
Copy link
Collaborator

cjmyers commented Jul 29, 2018

Here is the collection in my private repo:

https://synbiohub.org/user/myers/iGEM_2018/iGEM_2018_collection/1/f02adb98c7059047aa877380b11716ca872d82dc/share

Please let me know if you see any problems or if it is okay to post.

@jakebeal
Copy link

I think that we should keep the 2017 distribution as well: they are both reference points for many projects. If it's confusing to have both, then that's a UI challenge that SynBioHub needs to be able to handle better.

@cjmyers
Copy link
Collaborator

cjmyers commented Jul 29, 2018 via email

@jamesscottbrown
Copy link
Contributor Author

Previous distributions

I agree with Jake that keeping the details of previous distributions is a good idea.

I assume lots of teams will keep the plates in the freezer in case they're useful for the next year's team, and they'll want an index for them.

It would also allow users to do things like check what's changed between years from within SynBioHub, rather than having to scrape HTML tables or download separate excel files from the iGEM website.

Errors

I get an error trying to view the details for some (possibly all) of these parts. For example, this page gives the error:

Error: getType: https://synbiohub.org/public/igem/BBa_J04450/1/4711e114bb66fa516dcb97c86a357d7a7612d921/share not found
at sparql.queryJson.then (/home/deploy/synbiohub/lib/query/local/type.js:17:35)
at process._tickCallback (internal/process/next_tick.js:109:7)

@cjmyers
Copy link
Collaborator

cjmyers commented Jul 29, 2018 via email

@jamesscottbrown
Copy link
Contributor Author

jamesscottbrown commented Jul 29, 2018

It seems that collections form a hierarchy. The part you linked is listed as being a member of the collections:

//cds/reporter/chromoprotein  
//function/reporter/pigment  
Cell cjBlue, green chromoprotein  
Plasmid pSB1C3  
iGEM 2017 Distribution Plate 4  
iGEM 2017 Distribution Plate 4 Well 2I  
iGEM 2017 Distribution Plate 4 Well 2K  
iGEM 2017 Part Library  
iGEM Parts Registry  

But this could be written as:

//cds/reporter/chromoprotein  
//function/reporter/pigment  
Cell cjBlue, green chromoprotein  
Plasmid pSB1C3  
iGEM Parts Registry
        iGEM 2017 Part Library  
            iGEM 2017 Distribution Plate 4  
                iGEM 2017 Distribution Plate 4 Well 2I  
                iGEM 2017 Distribution Plate 4 Well 2K  

If the UI let users fold this hierarchical list (and perhaps folded at the level of "iGEM 2017 Part Library" or "iGEM PArts Registry" by default) then growth of this list would be less of a problem.

I have no idea how much effort would be involved in implementing this though.

@cjmyers
Copy link
Collaborator

cjmyers commented Jul 29, 2018 via email

@cjmyers
Copy link
Collaborator

cjmyers commented Jul 29, 2018 via email

@cjmyers
Copy link
Collaborator

cjmyers commented Jul 29, 2018

Issue with share links to public entries is fixed on dev server. See here:

https://dev.synbiohub.org/user/myers/iGEM_2018/iGEM_2018_Parts/1/6bcef4ec71cc0ff45aeea5448b91e13ad50b3398/share

@jamesscottbrown
Copy link
Contributor Author

That now works, but has a revealed a text encoding/escaping bug: the page for BBa_K925000 displays the name incorrectly as Δ12d, despite the name column in the table listing members of the collection displaying it correctly as Δ12d.

@cjmyers
Copy link
Collaborator

cjmyers commented Jul 29, 2018 via email

@jakebeal
Copy link

I also think that taking advantage of hierarchical structure would be a good idea. Sure, these aren't strictly hierarchical, but we should be able to indicate membership of a collection within another collection in a better way than right now, which sort of flattens everything.

@cjmyers cjmyers added this to the SBH 1.4.0 milestone Jul 31, 2018
@cjmyers cjmyers self-assigned this Jul 31, 2018
@cjmyers
Copy link
Collaborator

cjmyers commented Jul 31, 2018 via email

@jakebeal
Copy link

jakebeal commented Aug 1, 2018

Please test to make sure that when you do this it doesn't break the links coming in from iGEM, since teams are likely using these resources right now.

@cjmyers
Copy link
Collaborator

cjmyers commented Aug 1, 2018 via email

@jakebeal
Copy link

jakebeal commented Aug 1, 2018

If I go to the iGEM parts repository, and ask for the part in SBOL format, that links to something like: http://convert.sbols.org/biobrick.php?part=BBa_J23101

We need to make certain that doesn't break, even as we merge iGEM collection versions together.

@cjmyers
Copy link
Collaborator

cjmyers commented Aug 1, 2018 via email

@cjmyers cjmyers modified the milestones: SBH 1.4.0, SBH 1.5.0 Oct 3, 2018
@cjmyers cjmyers modified the milestones: SBH 1.5.0, SBH 1.4.0 Jan 1, 2019
@cjmyers
Copy link
Collaborator

cjmyers commented Jan 1, 2019

@cjmyers cjmyers closed this as completed Jan 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants