Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add css autoprefixer #93

Merged
merged 1 commit into from
Mar 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,20 @@

## 常见问题:

<details>
<summary>1. 我所在的地区有网络限制,怎么正常使用?</summary>

可以使用我们提供的[解决方案](https://github.com/ChatGPT-Desktop/ChatGPT-Desktop-Porxy)

</details>

<details>
<summary>2. MacOS 提示 app 已损坏,无法打开。</summary>
<img width='300' src='./images/problem-1.png' />

如何解决:参考 huazai 大佬的[解决办法](https://zhuanlan.zhihu.com/p/135948430)
参考 huazai 大佬的[解决办法](https://zhuanlan.zhihu.com/p/135948430)

</details>

## 如何贡献

Expand Down Expand Up @@ -119,8 +130,20 @@ npm run build:icon
- 提交文档校订
- 提交其他任何形式的贡献

#### Contributors
## Contact

- [Discord](https://discord.gg/jg4waryfA6)

## Star History

[![Star History Chart](https://api.star-history.com/svg?repos=ChatGPT-Desktop/ChatGPT-Desktop&type=Date)](https://star-history.com/#ChatGPT-Desktop/ChatGPT-Desktop&Date)

## Contributors

<a href="https://github.com/bilibili-ayang/ChatGPT-Desktop/graphs/contributors">
<img src="https://contrib.rocks/image?repo=bilibili-ayang/ChatGPT-Desktop" />
</a>

## License

[MIT](./LICENSE)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是一个关于 ChatGPT-Desktop 项目的代码补丁。以下是我的简要代码审核:

  1. 在常见问题部分,提供了解决网络限制的方案,很好。
  2. 在 MacOS 提示 app 已损坏无法打开时,参考 huazai 大佬的解决办法链接没有放在问题下面,应该将其放在“如何解决”这个小标题下面。
  3. 在贡献部分,列出了多种方式可以为项目做出贡献,很棒。
  4. 增加了联系方式,以及 Star 历史和许可证等信息。

总体来说,这个代码补丁看起来很不错。如果有任何漏洞或改进建议,欢迎提出。

6 changes: 5 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,14 @@
"@typescript-eslint/eslint-plugin": "^5.54.1",
"@typescript-eslint/parser": "^5.54.1",
"@vitejs/plugin-vue": "^4.0.0",
"autoprefixer": "^10.4.14",
"browserslist": "^4.21.5",
"eslint": "^8.35.0",
"eslint-config-prettier": "^8.7.0",
"eslint-plugin-prettier": "^4.2.1",
"eslint-plugin-vue": "^9.9.0",
"husky": "^8.0.3",
"lightningcss": "^1.19.0",
"lint-staged": "^13.1.2",
"prettier": "^2.8.4",
"prettier-plugin-tailwindcss": "^0.2.4",
Expand All @@ -61,10 +64,11 @@
"sass": "^1.58.3",
"typescript": "^4.6.4",
"unocss": "^0.50.4",
"unocss-preset-autoprefixer": "^0.0.5",
"unocss-preset-daisy": "^2.0.0",
"unplugin-auto-import": "^0.15.1",
"unplugin-vue-components": "^0.24.1",
"vite": "^4.0.0",
"vue-tsc": "^1.0.11"
}
}
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这段代码补丁添加了三个依赖项:autoprefixer、browserslist和lightningcss,以及一个新的Unocss预设unocss-preset-autoprefixer。此外,还有两个已有的依赖项更新了版本号。

对于这些更改,我有以下建议:

  • 检查这些新依赖项是否与现有代码库中的其他依赖项兼容。特别是,确保在使用这些新依赖项时没有任何错误或冲突。
  • 考虑在项目中使用npm audit检查安全漏洞,并解决任何问题。
  • 如果你使用的编辑器支持自动格式化,可以考虑将Prettier设置为自动格式化代码。这样可以确保整个代码库具有一致的格式和样式。
  • 对于未来的开发,考虑将ESLint配置文件更新为最新版本,并查看是否有任何更新的规则或最佳实践可以应用到你的代码库中。

181 changes: 177 additions & 4 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion src/assets/css/global.scss
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ code {

background-color: inherit;

-webkit-filter: blur(24px);
filter: blur(24px);
}
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这段代码补丁只是去掉了一个旧的CSS属性 "-webkit-filter: blur(24px);",这个属性在现代浏览器中已经不需要了。删除它不会增加任何风险,因为其他部分的CSS没有改变。如果您想要进一步改进代码,可以考虑优化CSS以提高性能和可维护性。

Expand Down
Loading