Cleaning up some exit codes

packages/cli/src/commands/socket-create.js

@@ -42,6 +42,7 @@ class SocketCreate {
     } catch (err) {
       debug(err)
       error(err.message)
+      process.exit(1)
     }
   }
 }

packages/cli/src/commands/socket-publish.js

@@ -23,6 +23,7 @@ export default class SocketPublishCmd {
         error(4)(err.message)
         echo()
       }
+      process.exit(1)
     }
   }
 }

packages/tests/e2e/cli/anonymous.test-e2e.js

@@ -20,13 +20,15 @@ describe('CLI Anonymous User', function () {
     testNixt()
       .run(`${cliLocation} list`)
       .stdout(/You are not logged in!/)
+      .code(1)
       .end(done)
   })
 
   it('can run cli deploy command', function (done) {
     testNixt()
       .run(`${cliLocation} list`)
       .stdout(/You are not logged in!/)
+      .code(1)
       .end(done)
   })
 })

packages/tests/e2e/cli/config.test-e2e.js

@@ -12,7 +12,7 @@ import {
 
 import {cliLocation, projectTestTemplate, configTestTemplate} from '../utils'
 
-describe('[E2E] CLI Config', function () {
+describe('CLI Config', function () {
   let testInstance = uniqueInstance()
 
   const moveTestSocket = (template) => {
@@ -34,38 +34,44 @@ describe('[E2E] CLI Config', function () {
       })
       .run(`${cliLocation} deploy hello-config`)
       .stdout(/socket synced:/)
+      .code(0)
       .end(done)
   })
 
   it('can set first config option', function (done) {
     testNixt()
       .run(`${cliLocation} config-set hello-config TEST1 test1_value`)
+      .code(0)
       .end(done)
   })
 
   it('can set second config option', function (done) {
     testNixt()
       .run(`${cliLocation} config-set hello-config TEST2 test2_value`)
+      .code(0)
       .end(done)
   })
 
   it('can show config of the socket', function (done) {
     testNixt()
       .run(`${cliLocation} config-show hello-config`)
       .stdout(/value: test2_value/)
+      .code(0)
       .end(done)
   })
 
   it('can change first config option of the socket', function (done) {
     testNixt()
       .run(`${cliLocation} config-set hello-config TEST1 test1_value_new`)
+      .code(0)
       .end(done)
   })
 
   it('can see new config option of the socket', function (done) {
     testNixt()
       .run(`${cliLocation} config-show hello-config`)
       .stdout(/value: test1_value_new/)
+      .code(0)
       .end(done)
   })
 
@@ -78,13 +84,15 @@ describe('[E2E] CLI Config', function () {
       .respond('test2\n')
       .on(/TEST3/)
       .respond('test2\n')
+      .code(0)
       .end(done)
   })
 
   it('can call hello-config socket endpoint', function (done) {
     testNixt()
       .run(`${cliLocation} call hello-config/hello`)
       .stdout(/test1 test2/)
+      .code(0)
       .end(done)
   })
 })

packages/tests/e2e/cli/deploy.test-e2e.js

@@ -13,7 +13,7 @@ import {
 
 import {cliLocation, projectTestTemplate} from '../utils'
 
-describe('[E2E] CLI Deploy', function () {
+describe('CLI Deploy', function () {
   let testInstance = uniqueInstance()
 
   const testNixt = () => nixt()
@@ -28,13 +28,15 @@ describe('[E2E] CLI Deploy', function () {
     testNixt()
       .run(`${cliLocation} list`)
       .stdout(/No Socket was found on server nor in config!/)
+      .code(0)
       .end(done)
   })
 
   it('can\'t list non existing Socket', function (done) {
     testNixt()
       .run(`${cliLocation} list ${getRandomString()}`)
       .stdout(/No Socket was found on server nor in config!/)
+      .code(1)
       .end(done)
   })
 
@@ -51,6 +53,7 @@ describe('[E2E] CLI Deploy', function () {
     testNixt()
       .run(`${cliLocation} deploy hello`)
       .stdout(/socket synced:/)
+      .code(0)
       .end(done)
   })
 
@@ -61,8 +64,8 @@ describe('[E2E] CLI Deploy', function () {
       .respond('TEST\n')
       .on(/Type in value for "lastname" parameter/)
       .respond('CLI\n')
-      .code(0)
       .stdout(/Hello TEST CLI/)
+      .code(0)
       .end(done)
   })
 
@@ -82,6 +85,7 @@ describe('[E2E] CLI Deploy', function () {
       .after(() => deleteInstance(testInstance))
       .run(`${cliLocation} deploy --create-instance ${testInstance}`)
       .stdout(/project synced:/)
+      .code(0)
       .end(done)
   })
 
@@ -104,6 +108,7 @@ describe('[E2E] CLI Deploy', function () {
       .after(() => deleteInstance(testInstance))
       .run(`${cliLocation} deploy --create-instance ${testInstance}`)
       .stdout(/Instance already exist!/)
+      .code(1)
       .end(done)
   })
 })

packages/tests/e2e/cli/hosting.test-e2e.js

@@ -11,7 +11,7 @@ import {
 
 import {cliLocation, projectTestTemplate, hostingAssets} from '../utils'
 
-describe('[E2E] CLI Hosting', function () {
+describe('CLI Hosting', function () {
   let testInstance = uniqueInstance()
   const hostingName = 'tests'
   const hostingName2 = 'tests2'
@@ -41,6 +41,7 @@ describe('[E2E] CLI Hosting', function () {
       .on(/sync files now/)
       .respond('\n')
       .stdout(/sync files use: syncano-cli hosting sync/)
+      .code(0)
       .end(done)
   })
 
@@ -56,6 +57,7 @@ describe('[E2E] CLI Hosting', function () {
       .on(/sync files now/)
       .respond('\n')
       .stdout(/sync files use: syncano-cli hosting sync/)
+      .code(0)
       .end(done)
   })
 
@@ -65,6 +67,7 @@ describe('[E2E] CLI Hosting', function () {
       .on(/Choose socket for which you you want to list hostings/)
       .respond('\n')
       .stdout(/name: tests/)
+      .code(0)
       .end(done)
   })
 
@@ -74,20 +77,23 @@ describe('[E2E] CLI Hosting', function () {
       .on(/Choose a socket which hosting files you want to see/)
       .respond('\n')
       .stdout(/You have 1 files/)
+      .code(0)
       .end(done)
   })
 
   it('can sync local hosting', function (done) {
     testNixt()
       .run(`${cliLocation} hosting sync ${hostingName}`)
       .stdout(/files synchronized/)
+      .code(0)
       .end(done)
   })
 
   it('can sync local hosting again', function (done) {
     testNixt()
       .run(`${cliLocation} hosting sync ${hostingName}`)
       .stdout(/files synchronized/)
+      .code(0)
       .end(done)
   })
 
@@ -100,6 +106,7 @@ describe('[E2E] CLI Hosting', function () {
       .respond('Y\n')
       .stdout(/CNAME: http:\/\/my.dom.ain/)
       .stdout(/BrowserRouter: ✓/)
+      .code(0)
       .end(done)
   })
 
@@ -108,6 +115,7 @@ describe('[E2E] CLI Hosting', function () {
       .run(`${cliLocation} hosting config ${hostingName} --browser-router false --remove-cname my.dom.ain`)
       .stdout(/^((?!CNAME: http:\/\/my.dom.ain)[\s\S])*$/)
       .stdout(/BrowserRouter: x/)
+      .code(0)
       .end(done)
   })
 
@@ -117,6 +125,7 @@ describe('[E2E] CLI Hosting', function () {
       .on(/Are you sure you/)
       .respond('Y\n')
       .stdout(/has been successfully deleted!/)
+      .code(0)
       .end(done)
   })
 
@@ -126,13 +135,15 @@ describe('[E2E] CLI Hosting', function () {
     .on(/Are you sure you/)
     .respond('Y\n')
     .stdout(/has been successfully deleted!/)
+    .code(0)
     .end(done)
   })
 
   it('can see there is not hosting containers', function (done) {
     testNixt()
       .run(`${cliLocation} hosting list`)
       .stdout(/You don't have any hostings/)
+      .code(0)
       .end(done)
   })
 })

packages/tests/e2e/cli/init.test-e2e.js

@@ -18,7 +18,7 @@ const { email, password, syncanoYmlPath } = returnTestGlobals()
 const tempPass = Date.now()
 const tempEmail = createTempEmail(process.env.E2E_CLI_TEMP_EMAIL, tempPass)
 
-describe('[E2E] CLI User', function () {
+describe('CLI User', function () {
   let testInstance = uniqueInstance()
 
   before(cleanUpAccount)
@@ -50,6 +50,7 @@ describe('[E2E] CLI User', function () {
       .stdout(/Project has been created from/)
       .match(syncanoYmlPath, /auth_key/)
       .match(syncanoYmlPath, /instance/)
+      .code(0)
       .end(done)
   })
 
@@ -59,6 +60,7 @@ describe('[E2E] CLI User', function () {
       .run(`${cliLocation} logout`)
       .stdout(/You have been logged out/)
       .unlink(syncanoYmlPath)
+      .code(0)
       .end(done)
   })
   // This is end of tests dependency
@@ -79,6 +81,7 @@ describe('[E2E] CLI User', function () {
       .match(syncanoYmlPath, /auth_key/)
       .match(syncanoYmlPath, new RegExp(testInstance))
       .unlink(syncanoYmlPath)
+      .code(0)
       .end(done)
   })
 
@@ -99,6 +102,7 @@ describe('[E2E] CLI User', function () {
       .match(syncanoYmlPath, /auth_key/)
       .match(syncanoYmlPath, /instance/)
       .unlink(syncanoYmlPath)
+      .code(0)
       .end(done)
   })
 
@@ -117,6 +121,7 @@ describe('[E2E] CLI User', function () {
       .match(syncanoYmlPath, /auth_key/)
       .match(syncanoYmlPath, /instance/)
       .unlink(syncanoYmlPath)
+      .code(0)
       .end(done)
   })
 })

packages/tests/e2e/cli/instance.test-e2e.js

@@ -8,7 +8,7 @@ import {
 
 import {cliLocation} from '../utils'
 
-describe('[E2E] CLI Instance', function () {
+describe('CLI Instance', function () {
   const testNixt = () => nixt()
     .env('SYNCANO_AUTH_KEY', process.env.E2E_CLI_ACCOUNT_KEY)
 
@@ -20,6 +20,7 @@ describe('[E2E] CLI Instance', function () {
       .after(() => deleteInstance(testInstance))
       .run(`${cliLocation} instance create ${testInstance}`)
       .stdout(/Instance already exist!/)
+      .code(1)
       .end(done)
   })
 
@@ -30,13 +31,15 @@ describe('[E2E] CLI Instance', function () {
       .after(() => deleteInstance(testInstance))
       .run(`${cliLocation} instance create ${testInstance}`)
       .stdout(/has been created/)
+      .code(0)
       .end(done)
   })
 
   it.skip('can list if there is no instances', function (done) {
     testNixt()
       .run(`${cliLocation} instance list`)
       .stdout(/You don't have any instances!/)
+      .code(0)
       .end(done)
   })
 
@@ -57,6 +60,7 @@ describe('[E2E] CLI Instance', function () {
       .stdout(/Instances:/)
       .stdout(new RegExp(testInstance1))
       .stdout(new RegExp(testInstance2))
+      .code(0)
       .end(done)
   })
 
@@ -69,6 +73,7 @@ describe('[E2E] CLI Instance', function () {
       })
       .run(`${cliLocation} instance delete ${testInstance}`)
       .stdout(/Instance was deleted successfully!/)
+      .code(0)
       .end(done)
   })
 })