Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Groups Implementation to Syncano Core #309

Merged
merged 5 commits into from
Oct 30, 2018
Merged

Conversation

jonny22094
Copy link
Contributor

No description provided.

@jonny22094 jonny22094 self-assigned this Oct 29, 2018
@codecov-io
Copy link

codecov-io commented Oct 29, 2018

Codecov Report

Merging #309 into master will decrease coverage by 0.92%.
The diff coverage is 84.48%.

@@            Coverage Diff             @@
##           master     #309      +/-   ##
==========================================
- Coverage   39.42%   38.49%   -0.93%     
==========================================
  Files          87       99      +12     
  Lines        2765     4159    +1394     
  Branches       10       10              
==========================================
+ Hits         1090     1601     +511     
- Misses       1674     2557     +883     
  Partials        1        1

packages/lib-js-core/src/groups.js Outdated Show resolved Hide resolved
packages/lib-js-core/src/groups.js Outdated Show resolved Hide resolved
@mkucharz
Copy link
Member

Other than those minor things, looks good. Way to go @jonny22094 ;)

@jonny22094 jonny22094 merged commit 0623427 into master Oct 30, 2018
@jonny22094 jonny22094 deleted the feat/core-lib-groups branch October 30, 2018 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants