Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to chat inside the VLC interface like on MPV #370

Closed
jvschiavo opened this issue Dec 15, 2020 · 9 comments
Closed

How to chat inside the VLC interface like on MPV #370

jvschiavo opened this issue Dec 15, 2020 · 9 comments

Comments

@jvschiavo
Copy link

Hi, I'd like to know if it is possible to chat inside VLC like on mpv by pressing enter. I have not managed to be able to do that, and didn't find any information regarding this.

(side-note, chatting on mpv on Linux only lets me use ASCII characters and not the special characters of portuguese like ã, ó, etc, but I can do so inside the syncplay window, does anyone know why?)

@Et0h
Copy link
Contributor

Et0h commented Dec 15, 2020

Hi, I'd like to know if it is possible to chat inside VLC like on mpv by pressing enter. I have not managed to be able to do that, and didn't find any information regarding this.

No, VLC does not support this. This is one of a number of reasons why we say Syncplay works best with mpv.

(side-note, chatting on mpv on Linux only lets me use ASCII characters and not the special characters of portuguese like ã, ó, etc, but I can do so inside the syncplay window, does anyone know why?)

The Syncplay's mpv Lua script only recognises certain keyboard inputs and they have to be hard coded. You can try adding them to Syncplayintf.lua as per aa5e7d8#diff-56ee60d65a2cf44bf413a63b22e9929b3eee302372fb67444e2e600ff7be9098 and if it works then make a pull request or post all the characters here.

@jvschiavo
Copy link
Author

jvschiavo commented Dec 15, 2020

Thanks for the quick and helpful answer!

I'm kinda curious as to what mpv has that VLC doesn't have that makes this possible. Is there any other player with this capability? Maybe could we add this to the VLC code?

Could we just add all the Unicode characters into that "non_us_chars" list? Or doing so would have any disadvantage? Because the benefit is instant support for all characters in languages (and even emoji I guess :P).

@Et0h
Copy link
Contributor

Et0h commented Dec 15, 2020

Thanks for the quick and helpful answer!

I'm kinda curious as to what mpv has that VLC doesn't have that makes this possible. Is there any other player with this capability? Maybe could we add this to the VLC code?

If you look at https://github.com/Syncplay/syncplay/blob/master/syncplay/resources/syncplayintf.lua you will see that to get in-player chat working in mpv we:
(a) Have dynamic key binding to capture the input keys and temporarily supress any other bindings they might be associated with; and
(b) Display input as it is being typed using a custom OSD layer, with text wrapping.

My understanding is that the only media player which supports (a) is mpv. If anyone wants to try getting that to work in VLC then feel free.

Could we just add all the Unicode characters into that "non_us_chars" list? Or doing so would have any disadvantage? Because the benefit is instant support for all characters in languages (and even emoji I guess :P).

I don't think that is possible within mpv at present, but you could ask an mpv developer to see determine there is a sensible way to do it.

It has been stated that "as of Version 13.0, the Unicode Standard contains 143,859 characters" - I don't think mpv would be happy if we tried binding them all. Also, who has an emoji keyboard? If people want emojis then they can paste them into the Syncplay chat input (or into mpv using ctrl+v while the input mode is on, but it does cause a slight pause so is not ideal).

For now our approach is that if people find characters they want to use but cannot they can submit a request to add one, specifying the precise characters in all desired cases.

@jvschiavo
Copy link
Author

jvschiavo commented Dec 23, 2020

The only characters that I can think of that we need and might be missing are those:
ç ñ
´ á é í ó ú
` à è ì ò ù
^ â ê î ô û
~ ã ẽ ĩ õ ũ
¨ ä ë ï ö ü

By the way, a friend of mine realized some of those characters are already in the script, but they don't work because it is missing support for something like "dead keys". She said that in most languages we use dead keys to input some characters, and it is not working, so we can't input most of them.

@soredake
Copy link
Contributor

Any progress on this?

@Et0h
Copy link
Contributor

Et0h commented Feb 13, 2021

Okay, I've added to characters and then deleted the suspected duplicates - if they don't work then that is probably an mpv or OS issue rather than a Syncplay issue. There might be some workaround in terms of detecting ctrl/shift plus a different character, but I don't use the relevant keyboards so would not be able to implement such a workaround. As such, I'm closing this issue as I've got as far as I can on it but if someone wants to make a pull request with further improvements then feel free.

@Et0h Et0h closed this as completed Feb 13, 2021
@AtilioA
Copy link
Contributor

AtilioA commented May 23, 2021

Neither 3e03747 nor d3f2c43 work for me on Windows 10. Previous behavior was no special characters appeared at all; now they appear as soon as they are pressed (and not compounded to the letters).
Update: Didn't work on Linux either.

@AtilioA
Copy link
Contributor

AtilioA commented Oct 16, 2021

@Et0h shouldn't this issue remain open if someone wants to tackle this, as the problem still persists? In fact, it's probably better to open another issue since this problem is just a side note to the current issue, which should be closed; I could open the new issue. I've messed with the bindings variable but I could not bind '´+e' to produce é, for example.

@Et0h
Copy link
Contributor

Et0h commented Oct 16, 2021

@Et0h shouldn't this issue remain open if someone wants to tackle this, as the problem still persists?

Suggested enhancement aren't really 'issues'. However, I can put it over to a 'discussion' to see if anyone wants to give it a try.

@Et0h Et0h reopened this Oct 16, 2021
@Syncplay Syncplay locked and limited conversation to collaborators Oct 16, 2021
@Et0h Et0h closed this as completed Oct 16, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Projects
None yet
Development

No branches or pull requests

5 participants