MPV: Add the possibility to control which socket to use #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for trying to help us cover more use cases. Have you tested the PR with SVP-project? If so, what is the usage instructions on how to get it to work? |
|
Yes, I tested it but only on Linux. To make it work with SVP-project it is enough to just specify in the player flags: |
|
I'll need to test this, but it seems like a good improvement. |
|
Test it and it all looks good :) |
albertosottile
pushed a commit
to albertosottile/syncplay
that referenced
this pull request
Sep 30, 2020
Co-authored-by: Denis Fomin <dfomin@retechlabs.com>
albertosottile
pushed a commit
to albertosottile/syncplay
that referenced
this pull request
Sep 30, 2020
Co-authored-by: Denis Fomin <dfomin@retechlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow MPV users to set a custom socket via input-ipc-server flag. This will make possible simultaneous use of Syncplay and other tools like SVP-project