improvement(gossip): replace all uses of std.time.milliTimestamp as a PRNG seed with a std.Random interface parameter

[aang114]

For all the functions that are directly generating random numbers using a PRNG (where the seed used is std.time.milliTimestamp), a std.Random interface parameter has now been added which generates the random numbers instead. This is done to decouple the actual PRNG implementation and its seed from the function.

This decoupling is useful during testing since we can easily find out the specific PRNG seed used when the function fails.

The functions that were modified are:

• Bloom.random()
• GossipPullFilterSet.consumeForGossipPullFilters()
• GossipService.buildPullRequests()
• NodeInstance.init()
• ActiveSet.rotate()

Note: This PR attempts to resolve issue #176.

Update(27 Jun 2024): Based on @InKryption's review, a std.Random interface parameter has also been added to the following functions:

• ContactInfo.toNodeInstance()
• GossipPullFilterSet.initTest()
• GossipService.rotateActiveSet()

Update 2(27 Jun 2024): Based on @InKryption's second review, a std.Random interface parameter has also been added to the following functions:

• buildGossipPullFilters()
• GossipPullFilterSet.init()

[InKryption]

This is a good start, but there appears to be a misunderstanding about the intention of the original logging code, and a few places where the change could, and must eventually go further.

The superfluous logs should be removed. As for going further with the hoisting of the PRNG implementation, efforts would be appreciated, but are not vital & can be done as part of future work.

[InKryption]

Looking better, a few more amendments are in order and then this should be good to go.