feat(kcov): add code coverage support for tests + fuzzers #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
example coverage run https://github.com/Syndica/sig/actions/runs/9896446984/job/27338682812?pr=193 |
InKryption
reviewed
Jul 11, 2024
…#195) * running kcov on the unit tests lead to finding important code paths we werent testing - this pr adds these units tests - this includes tests for both gossip and accounts-db
* add fuzz testing for the gossip table
|
note: the two prs merged (in the last two commits) were built off of this main pr - so i merged them to make review easier the summary of the two prs include:
|
InKryption
requested changes
Jul 16, 2024
InKryption
previously requested changes
Jul 17, 2024
There was a problem hiding this comment.
One final small review & inquiries of some stylistic & correctness details. After this pass-over I'm happy.
Also, I think it would be good to dedicate a separate PR for porting the shell scripts to zig, to avoid delaying the merge of the rest of these already extremely valuable changes due to potential hiccups in that process.
yewman
reviewed
Jul 17, 2024
yewman
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/fuzzing.mdscripts/kcov_test.shfor how to run kcov on teststhe goal is to use code coverage to improve pr reviews and understand where things are and aren't being tested - not as a metric to optimize to 100% coverage
TODO: move sh scripts to the zig system