Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require 'static for TStatusPayload of StatusOperationMessage #14

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Require 'static for TStatusPayload of StatusOperationMessage #14

merged 1 commit into from
Dec 16, 2023

Conversation

jackh726
Copy link
Contributor

This crate currently relies on a bug in the compiler, and will stop compiling after rust-lang/rust#118553.

The impl of Message for StatusOperationMessage<T> has a bound of T: 'static, but this isn't enforced on these functions. This is technically a breaking change, but should be required.

@jackh726 jackh726 changed the title Require for TStatusPayload of StatusOperationMessage Require 'static for TStatusPayload of StatusOperationMessage Dec 13, 2023
@Syndim
Copy link
Owner

Syndim commented Dec 16, 2023

LGTM

@Syndim Syndim merged commit 6852863 into Syndim:master Dec 16, 2023
@jackh726 jackh726 deleted the incorrect-implied-bounds branch December 16, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants