Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can no longer install numba with python 2 #45

Closed
KrisThielemans opened this issue Jun 4, 2020 · 5 comments · Fixed by #49
Closed

Can no longer install numba with python 2 #45

KrisThielemans opened this issue Jun 4, 2020 · 5 comments · Fixed by #49
Assignees

Comments

@KrisThielemans
Copy link
Member

KrisThielemans commented Jun 4, 2020

The synergistic demos use brainweb, which starts by using pip install numba. That now fails:

 running bdist_wheel
  /usr/bin/python /tmp/pip-install-sW2ewi/llvmlite/ffi/build.py
    File "/tmp/pip-install-sW2ewi/llvmlite/ffi/build.py", line 122
      raise ValueError(msg.format(_ver_check_skip)) from e
                                                       ^
  SyntaxError: invalid syntax

Also seen here https://stackoverflow.com/questions/61925676/can%c2%b4t-install-numba-for-python with a comment "try a new version of Python".

Is there a work-around? Do we need numba or can we make it optional (without a lot of work).

This is currently a problem as our VM is still stuck on Python 2

@casperdcl
Copy link
Member

I think numba is a leftover from some performance hacks @rijobro was trying - looks like it can be removed.

rijobro added a commit that referenced this issue Jun 4, 2020
@KrisThielemans
Copy link
Member Author

Serves us right from not upgrading to Python 3. @paskino, this will have to be a priority after 2.2 (unless it's a matter of dropping in ubuntu 20.04, but that seems unlikely!)

I suggest to move the import numba to a new cell, but commented out, saying that they can uncomment it and subsequent @jit lines if they have python3 (and numba).

@casperdcl
Copy link
Member

How much of a speedup does it really give in those notebooks? May just be better to leave it out...

@rijobro
Copy link
Contributor

rijobro commented Jun 4, 2020

Comment from a notebook says

Using jit gets computation time from 90 secs to 2!

So I'm inclined to comment it out rather than delete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants