Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

synergistic/BrainWeb-single_slice_motion.ipynb fails on python 2 due to os.makedirs #46

Closed
KrisThielemans opened this issue Jun 4, 2020 · 1 comment · Fixed by #47
Closed

synergistic/BrainWeb-single_slice_motion.ipynb fails on python 2 due to os.makedirs #46

KrisThielemans opened this issue Jun 4, 2020 · 1 comment · Fixed by #47

Comments

@KrisThielemans
Copy link
Member

code is

if not path.isdir(data_path):
    os.makedirs(data_path, exist_ok=True)

This fails on Python 2 as exist_ok didn't exist (...). However, it seems unnecessary as we check existence first.
rijobro added a commit that referenced this issue Jun 4, 2020
@rijobro
fixes python2 makedirs(exist_ok)
c777af2 
fixes #46
@rijobro rijobro mentioned this issue Jun 4, 2020
Merged
@KrisThielemans
Copy link
Member Author

same for Brainweb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes python2 makedirs(exist_ok) SyneRBI/SIRF-Exercises
1 participant
@KrisThielemans