Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor simplification of VB/bootstrap_ubuntu.sh #739

Closed
KrisThielemans opened this issue Jul 12, 2022 · 0 comments · Fixed by #758
Closed

minor simplification of VB/bootstrap_ubuntu.sh #739

KrisThielemans opened this issue Jul 12, 2022 · 0 comments · Fixed by #758
Assignees
@paskino
Labels
enhancement

Comments

@KrisThielemans
Copy link
Member

This script contains

SIRF-SuperBuild/VirtualBox/scripts/bootstrap_ubuntu.sh

Lines 74 to 76 in ec4b9c5

bash $userHOME/devel/SIRF-SuperBuild/VirtualBox/scripts/INSTALL_prerequisites_with_apt-get.sh
bash $userHOME/devel/SIRF-SuperBuild/VirtualBox/scripts/INSTALL_CMake.sh /usr/local
bash $userHOME/devel/SIRF-SuperBuild/VirtualBox/scripts/INSTALL_python_packages.sh

As we have

SIRF-SuperBuild/VirtualBox/scripts/UPDATE.sh

Lines 157 to 159 in ec4b9c5

sudo -H ./INSTALL_prerequisites_with_apt-get.sh
sudo -H ./INSTALL_python_packages.sh --python "$PYTHON_EXECUTABLE"
sudo -H ./INSTALL_CMake.sh

I think bootstrap_ubuntu.sh can simply use UPDATE.sh -s, which would be simpler.

The difference would be that UPDATE.sh -s runs `configure_gnome.sh. I'm not sure why it does that though. It looks a bit dangerous as people who update their VM could be overwriting their gnome settings.

Not urgent of course
@KrisThielemans KrisThielemans mentioned this issue Jul 12, 2022
Open
KrisThielemans added a commit to KrisThielemans/SIRF-SuperBuild that referenced this issue Aug 18, 2022
@KrisThielemans
VM: UPDATE.sh no longer runs configure_gnome.sh
2e83381 
This seems dangerous as it could override user settings.
In addition, it allows us to simplify the bootstrap script a bit.
This also means that INSTALL*sh scripts appropriate to the desired version are used
(before they were the ones on master).

Fixes SyneRBI#739
KrisThielemans added a commit to KrisThielemans/SIRF-SuperBuild that referenced this issue Aug 18, 2022
@KrisThielemans
VM: UPDATE.sh no longer runs configure_gnome.sh
ee756e5 
This seems dangerous as it could override user settings.
In addition, it allows us to simplify the bootstrap script a bit.
This also means that INSTALL*sh scripts appropriate to the desired version are used
(before they were the ones on master).

I had to split the optional updates then however, as apt needs to be run
before we can find the python executable. Similarly, python updates have
to be run before we can find cython.

Fixes SyneRBI#739
KrisThielemans added a commit to KrisThielemans/SIRF-SuperBuild that referenced this issue Aug 18, 2022
@KrisThielemans
VM: UPDATE.sh no longer runs configure_gnome.sh
6c038ec 
This seems dangerous as it could override user settings.
In addition, it allows us to simplify the bootstrap script a bit.
This also means that INSTALL*sh scripts appropriate to the desired version are used
(before they were the ones on master).

I had to split the optional updates then however, as apt needs to be run
before we can find the python executable. Similarly, python updates have
to be run before we can find cython.

Fixes SyneRBI#739
@KrisThielemans KrisThielemans mentioned this issue Aug 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paskino paskino

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

VirtualBox scripts cleanup KrisThielemans/SIRF-SuperBuild
2 participants
@KrisThielemans @paskino