Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glog needs upgrade #778

Closed
KrisThielemans opened this issue Nov 23, 2022 · 1 comment · Fixed by #780
Closed

glog needs upgrade #778

KrisThielemans opened this issue Nov 23, 2022 · 1 comment · Fixed by #780
Milestone

Comments

@KrisThielemans
Copy link
Member

when compiling with C++-17 we get an error

ISO C++17 does not allow dynamic exception specifications

This seems to disappear with release-1.12.1

@KrisThielemans KrisThielemans added this to the v3.4 milestone Nov 23, 2022
KrisThielemans added a commit to KrisThielemans/SIRF-SuperBuild that referenced this issue Nov 23, 2022
KrisThielemans added a commit to KrisThielemans/SIRF-SuperBuild that referenced this issue Nov 23, 2022
@KrisThielemans KrisThielemans changed the title GTest needs upgrade glog needs upgrade Nov 23, 2022
@KrisThielemans
Copy link
Member Author

oops, it is actually an error in glog

KrisThielemans added a commit that referenced this issue Nov 23, 2022
* Use GTest 1.12.1

* updated glog to v0.6.0

Fixes #778
KrisThielemans added a commit that referenced this issue Dec 12, 2022
* Use GTest 1.12.1

* updated glog to v0.6.0

Fixes #778
paskino added a commit that referenced this issue Mar 2, 2023
* allows user to pass CBLAS_LIBRARY and CBLAS_INCLUDE_DIR

the CBLAS library needed by Gadgetron is currently found by Gadgetron's CMake.
However, in the case that this fails the user can pass the variable
CBLAS_LIBRARY and CBLAS_INCLUDE_DIR pointing to the cblas library and
the location of cblas.h respectively. These are passed to Gadgetron's cmake as
cached variables.

* added range-v3 dependency for Gadgetron
* creates env_ccppetmr.* symbolic links
* updates to build Gadgetron master
* add dependency for rocksdb
* add librocksdb-dev
* add pugixml
* use ISMRMRD master
* bump GTest version
* add JSON as dependency for Gadgetron and bumb version
* bump Boost version to 1.78
* add libBoost context
* add RocksDB
* skip copying of missing config file
gadgetron/gadgetron#1024
* bump siemens_to_ismrmrd commit
* add CPR to Gadgetron dependencies
* add libboost-optional-dev
* update boost dependency and build gadgetron testing
* Add Date dependency
* remove CPR dependency from Gadgetron
* add golang to list of apt packages
* change build command for mrd-storage-server
* Use GTest 1.12.1 and glog 0.6.0 (#780)
Fixes #778
* added pytest to requirements.txt
* added pytest-cov to requirements
* update range-v3 to 0.12.0
Merge master
* install pkg-config
* remove range-v3 from devel build
* add GCC 11 non devel build
* add option DISABLE_range-v3_TESTING
* simplified Gadgetron USE CUDA logic
* update CHANGELOG
* simplify Gadgetron external project
* closes #776
---------

Co-authored-by: Evgueni Ovtchinnikov <evgueni.ovtchinnikov@stfc.ac.uk>
Co-authored-by: Kris Thielemans <k.thielemans@ucl.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant