Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable hdf5 by default #407

Merged
merged 2 commits into from
Jun 5, 2020
Merged

Conversation

rijobro
Copy link
Contributor

@rijobro rijobro commented Jun 4, 2020

In spite of #404, STIR HDF5 support still being built on PRs, causing them to fail: https://travis-ci.org/github/SyneRBI/SIRF-SuperBuild/jobs/694165572#L22214-L22217.

I'm guessing this is because there are two bools controlling it in STIR. Set them to both use the same boolean SuperBuild value.

@KrisThielemans
Copy link
Member

There has never been a DISABLE_HDF5_SUPPORT as far as I can see. It certainly is DISABLE_HDF5 in STIR release_4 branch (it isn't yet anywhere else I believe).

@KrisThielemans
Copy link
Member

please remove the *SUPPORT variable therefore

@rijobro rijobro merged commit 557e89a into SyneRBI:master Jun 5, 2020
@rijobro rijobro deleted the option_disable_hdf5 branch June 5, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants