Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_trajectory does not return the trajectory but recalculates it #1205

Open
ckolbPTB opened this issue Jul 21, 2023 · 0 comments
Open

get_trajectory does not return the trajectory but recalculates it #1205

ckolbPTB opened this issue Jul 21, 2023 · 0 comments

Comments

@ckolbPTB
Copy link
Contributor

We have got the function set_data_trajectory which allows users to set the values of the k-space trajectory.

We also have to function get_data_trajectory which as far as I understand does not return the content of the k-space trajectory but actually recalculates it here

Nikos came across this problem, because he has got spiral acquisitions and he sets the trajectory with set_data_trajectory. When he then calls get_data_trajectory he gets an array of zeros because the calculation of spiral trajectories is not implemented in SIRF.

Should we rename get_data_trajectory to calc_data_trajectory and throw an error if the trajectory is SPIRAL and then implement a proper get_data_trajectory which returns the content of the trajectory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant