Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added pass through of threshold for recon #544

Conversation

ALEXJAZZ008008
Copy link
Member

No description provided.

Copy link
Member

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Can you add some doc? (hopefully can steal it from STIR) Ideally add it to MATLAB but you might not be able to test that, in which case it's a bad idea.

@evgueni-ovtchinnikov, how do you keep track of what features still need to be ported to MATLAB?

@ALEXJAZZ008008 please add a line in CHANGES.md

@KrisThielemans
Copy link
Member

@ALEXJAZZ008008 could you give this a quick look such that we can merge it in before 2.2? Should only take 5 mins to add in the doc. I don't see why this PR should be updating the data submodule though. As that's rather fragile, I'd vastly prefer if it doesn't.

@ALEXJAZZ008008
Copy link
Member Author

Yes, I'll look at this first thing tomorrow.
I agree that there shouldn't be changes to data I believe this will be because I used "got add ."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants