Option to use symmetric f3d. default to off #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AnderBiguri could you give this a go for me and confirm? Since use_symmetric defaults to off, python and matlab should both use the non-symmetric version by default now. I haven't bothered exposing that option (since the functionality is broken). Suppose I'll add something to the doxygen and Changes.md |
|
@rijobro Confirmed! This works without permuting the output. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #680.
Added a test that says "if ref==flo, I expect registered image to ~= ref". This test fails with old (symmetric) implementation, but passes for the new fix.