Skip to content
This repository has been archived by the owner on Aug 20, 2022. It is now read-only.

Python3 build #170

Merged
merged 18 commits into from
Apr 19, 2021
Merged

Python3 build #170

merged 18 commits into from
Apr 19, 2021

Conversation

paskino
Copy link
Contributor

@paskino paskino commented Jun 11, 2020

Updates scripts and packages to build with SIRF with python3.

@paskino
Copy link
Contributor Author

paskino commented Jun 11, 2020

Notice that it is needed to install cython and cython3 because some of the prerequisites in the SuperBuild build with python2 apparently.

@paskino
Copy link
Contributor Author

paskino commented Jun 11, 2020

This also means that some packages in the SuperBuild pick the wrong python version and I'm not entirely sure which one.

@KrisThielemans
Copy link
Member

I think this will be premature to merge for 2.2. We can of course always release another VM afterwards.

Possibly this could be resolved by tackling SyneRBI/SIRF-SuperBuild#48.

@rijobro
Copy link
Contributor

rijobro commented Jun 12, 2020

As discussed previously, we could potentially switch to 20.04 meaning that it would use python3 by default. Might fix some problems without any effort on our part.

Would require fixing SyneRBI/SIRF-SuperBuild#413.

@KrisThielemans
Copy link
Member

without any effort on our part

seems somewhat wishful thinking, given Alex's struggles 😉

In any case, finding correct Python versions will remain a bane. Maybe not on a clean Ubuntu 20.04 VM, but as soon as conda gets involved, it'll be a load of fun to be sure we don't mix conda and system python.

scripts/UPDATE.sh Outdated Show resolved Hide resolved
scripts/UPDATE.sh Outdated Show resolved Hide resolved
Copy link
Member

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. aside from these 2, ready to merge

scripts/bootstrap_ubuntu.sh Outdated Show resolved Hide resolved
scripts/bootstrap_ubuntu.sh Outdated Show resolved Hide resolved
Copy link
Member

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comment that remain to be resolved. In addition, https://github.com/SyneRBI/SyneRBI_VM/blob/master/documentation/Getting-started-with-SIRF.md needs updating as it says python and talks about spyder versions.

@paskino paskino merged commit c128989 into master Apr 19, 2021
@paskino paskino deleted the python3_build branch April 19, 2021 12:58
@KrisThielemans KrisThielemans mentioned this pull request Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants