Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Facebook Login Feature #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vidit21srivastava
Copy link

Have you read the Contributing Guidelines?

Yes

Describe the problem you were trying to solve.

I was trying to implement Facebook Login Feature In the Login Page

Description of codes you added

ScreenShots of changes(optional)

(Attach images here.)

Related Issues or Pull Requests

(Write your answer here.)

@Rivatus
Copy link
Collaborator

Rivatus commented Dec 29, 2021

The proposed PR code is not even compiling.
Firstly the version of react-facebook-login is incorrectly specified to some unreleased version (in package.json)
Secondly the modified login.js file has compilation error.
Even after correcting those things the Facebook-login feature is not interacting (passing value, logging in) with our server side's code.
There are many corrections needed.

@vidit21srivastava
Copy link
Author

I am doing fixups for versions, but I haven't provided the appid for facebook login api intentionally as it would all time went through my facebook developer id. Kindly suggest some alternatives.

@vidit21srivastava
Copy link
Author

Screenshot 2021-12-30 043855
Issue Solved Its Working

@vidit21srivastava
Copy link
Author

I have made a commit kindly review it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants