Rework mc (midnight commander) of synocli-file #3837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- SynoCommunity#3834 add sftp support and hence add cross/libssh2 - SynoCommunity#3783/ SynoCommunity#3258 fix mouse handling - replace usage of ncurses by slang - add patch to fix subshell for /bin/sh shell linked to /bin/bash (subshell for /bin/sh is not supported) - add new mc icon - update synocli-file with reworked mc
ymartin59
reviewed
Jan 4, 2020
spk/synocli-file/Makefile
Outdated
| @@ -1,37 +1,30 @@ | |||
| SPK_NAME = synocli-file | |||
| SPK_VERS = 1.0 | |||
There was a problem hiding this comment.
I propose to increase package version itself too
Suggested change
| SPK_VERS = 1.0 | |
| SPK_VERS = 1.1 |
There was a problem hiding this comment.
My intent is to update revision for updated components and update the version with adding/removing components.
But we could use major/minor package version for this.
There was a problem hiding this comment.
I prefer the other way "major/minor" to get a reason to increase major from time to time...
spk/synocli-file/Makefile
Outdated
|
|
||
| MAINTAINER = SynoCommunity | ||
| DISPLAY_NAME = SynoCli File Tools | ||
| ifneq ($(findstring $(ARCH), powerpc ppc824x ppc853x ppc854x $(ARM5_ARCHES)),$(ARCH)) | ||
| # to build rnm, GCC >= 4.8 is required, but not contained in older toolchains. | ||
| DEPENDS += cross/rnm | ||
| DESCRIPTION = "SynoCli File Tools provides a set of small command-line utilities: less, tree, ncdu, jdupes, rhash, mc \(midnight commander\), nano, file, detox, rmlint, rnm." |
There was a problem hiding this comment.
Just an idea to avoid duplicated DESCRIPTION: use a variable for only variable part content ", rnm" with list of tools according to condition...
ymartin59
approved these changes
Jan 4, 2020
|
sorry, just found that rmlint does not compile for ppc853x, so I removed the label "status/to-publish". |
This was referenced Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: Handle reported issues and fix subshell for the synology way to define /bin/sh as link to /bin/bash
Linked issues: #3834, #3783, #3258
Checklist
all-supportedcompleted successfully