py311-310: Update to latest version #5866
Conversation
@hgy59 Always a pleasure. Note that I am temporary marking EDIT: I finally had to revert upgrading |
|
@hgy59 everything should now be solved and build to complete sucessfully. Last thing I noticed is znc failing on DSM7 with github-action but I can't reproduce this on my end?! Can you check on your side if you're able to reproduce in your environment? |
We already faced this #5820 (comment) |
This is a bad idea. Homeassistant must build here (as it did before). #5857 is only a runtime dependency fix for IKEA tradfri (I forgot to include cross/dtlssocket). Everything else (i.e. the current version) must build as it did in #5757 based on #5820. |
|
@th0ma7 another small issue
probably it is obvious (in your eyes) and can be fixed for future builds (similar issue in python 3.10). |
|
@th0ma7 homeassistant fails to build numpy 1.23.2 any idea on how to fix this? |
pythonclean: will cleanup the crossenv directory pythoncleanall: will cleanup all python build files
@hgy59 yes, now fixed. Had to revert |
@hgy59 actually this isn't an issue. By default python311 is built with close to no wheels being included. When testing all wheels building indeed it test out that cryptography does work both from cross AND from requirement files. It's not an issue but rather a confirmation that all is working OK. At the end of day, python311 provided online will not provide any of that but rather the bare minimal wheels from |
Thnx for the reminder... I'll investigate and check if I can find something out to enforce it to work out on DSM7 on github-action so we can get clean builds. |
It still does not find openssl on DSM 7.x is says found: yes, but usable no full log of znc build for x64-7.1 |
|
@th0ma7 again, I would not postpone this PR for finding a solution for znc and DSM 7.1. Or - to validate my guess, we could move znc to the head of the package list for the gh build action (just after python3* and ffmpeg*) - but IMHO it is still not worth the effort. |
|
@hgy59 I believe I have now sort out issues with |
|
@hgy59 |
|
@hgy59 theses are my last two testing use-cases in hope for fixing ZNC. In the meantime I did resolved something else which allowed me to remove All in all, it's looking promising but if ZNC fails to build online I'll remove the speicifcs for it and my re-convert it back to normal build process. EDIT: I've now moved the "exceptions" needed for ZNC directly within ZNC cross file. EDIT2: And also noticed that vim wasn't migrated to python311 yet... |
spk/vim/Makefile
Outdated
| DEPENDS = cross/$(SPK_NAME) | ||
| PYTHON_PACKAGE = python311 | ||
| SPK_DEPENDS = "python311>=3.11.5-8" | ||
| UNSUPPORTED_ARCHS = $(OLD_PPC_ARCHS) $(ARMv5_ARCHS) | ||
|
|
||
| MAINTAINER = SynoCommunity |
There was a problem hiding this comment.
Since python is an optional dependency for the vim package, we must not add "SPK_DEPENDS"
There was a problem hiding this comment.
@th0ma7 we could either use python310 for those archs or drop python support.
We should keep off the hardcoded dependency of python, since python support is optionally and must be manually configured by the user.
There was a problem hiding this comment.
@th0ma7 probably I am wrong with the "manually configure vim for python" but vim can be built with or without the python feature.
There was a problem hiding this comment.
@hgy59 do you mind if we revisit this to a later time? I agree that it can certainly be worked out differently, and would benefit from an update also. But for the sake of py311 upgrade I'd keep it as is...?
There was a problem hiding this comment.
@th0ma7 if you want to postpone this, then please leave PYTHON_PACKAGE for vim at python310 to keep the packages for OLD_PPC_ARCHS and ARMv5_ARCHS.
And please remove SPK_DEPENDS.
|
@hgy59 success at last! |
spk/vim/Makefile
Outdated
| ifneq ($(findstring $(ARCH),$(ARMv5_ARCHS) $(OLD_PPC_ARCHS)),$(ARCH)) | ||
| SPK_DEPENDS = "python311>=3.11.5-8" | ||
| endif | ||
|
|
There was a problem hiding this comment.
Can't we keep this dependency optional and remove the SPK_DEPENDS?
So (as before) you can install vim without python, but you can't use the python feature until you install python311.
If one wants to use the python feature, now python311 is needed and can be installed before or after the vim package.
So the changelog must change 2. Migrate to Python 3.11 to 2. You now need Python 3.11 to enable Python support.
Probably it is not enough to mention this in the changelog, and we should add a note (except for ARMv5 and OLD_PPC) to the package description(s) like:
"To enable Python support you need to install the Python 3.11 package"
sorry to remain pedantic, but why sould a user need to install python for the update, when the python feature is not needed?
There was a problem hiding this comment.
This really was to demonstrate two things:
- it's still possible to build
vimfor armv5 - it's also possible to migrate
vimto python 3.11
As far as python being optional, I had not looked into that just yet. Indeed it can be but there is a need to provide proper messaging on that matter... And not sure the changlog is the best but certainly is the easiest (wizard perhaps would be better but more complex due to arch build differences?). Personnally I find making it mandatory by default is the simplest and safest.
But AFAIK you seem to object to that therefore I can change this easily by switching SPK_DEPENDS to a changelog += instead. Before I make the necessary changes, would that meet your train of thoughts?
There was a problem hiding this comment.
@hgy59 Would 1a355eb + 59b561d suit your need? I've checked and the INFO looks OK from a " perspective:
$ cat work-88f6281-6.2.4/INFO
package="vim"
version="9.0-6"
description="Vim is a highly configurable text editor built to enable efficient text editing. It is an improved version of the vi editor distributed with most UNIX systems."
description_csy="Vim je pokročilý textový editor, který usiluje o to poskytnout sílu de-facto Unixového editoru Vi, s komplexnější sadou vlastností."
description_fre="Vim est un éditeur de texte avancé basé sur Vi (unix) avec des fonctions plus complètes."
arch="88f6281"
maintainer="SynoCommunity"
maintainer_url="https://github.com/SynoCommunity"
distributor=""
distributor_url=""
os_min_ver="6.2-25556"
helpurl="https://www.vim.org/"
ctl_stop="no"
displayname="Vim"
dsmappname="com.synocommunity.packages.vim"
changelog="1. Update vim to v9.0"
checksum="2d40a3b4be313ac1f3f7737fb25b698b"
$ cat work-x64-7.1/INFO
package="vim"
version="9.0-6"
description="Vim is a highly configurable text editor built to enable efficient text editing. It is an improved version of the vi editor distributed with most UNIX systems."
description_csy="Vim je pokročilý textový editor, který usiluje o to poskytnout sílu de-facto Unixového editoru Vi, s komplexnější sadou vlastností."
description_fre="Vim est un éditeur de texte avancé basé sur Vi (unix) avec des fonctions plus complètes."
arch="apollolake avoton braswell broadwell broadwellnk broadwellnkv2 broadwellntbap bromolow cedarview denverton epyc7002 geminilake grantley kvmx64 purley r1000 v1000"
maintainer="SynoCommunity"
maintainer_url="https://github.com/SynoCommunity"
distributor=""
distributor_url=""
os_min_ver="7.1-42661"
helpurl="https://www.vim.org/"
ctl_stop="no"
displayname="Vim"
dsmappname="com.synocommunity.packages.vim"
changelog="1. Update vim to v9.0 <br/>2. Migrate to Python 3.11 <br/><br/>NOTE: You need to install Python 3.11 package to enable Python support."
checksum="721d1b9df75c45c26927d4dcfef56b52"
Co-authored-by: hgy59 <hpgy59@gmail.com>
Description
Update to Python 3.10.13 and 3.11.5.
Fixes #5855, fixes #5841, fixes #5857 and possibly #5847
Notes:
PyYamlis broken withCython>= 3.x "AttributeError: cython_sources" with Cython 3.0.0a10 yaml/pyyaml#601 thus keep using older version of Cython 0.29.x for thecrossenvcreationarmv5support due to missinglibatomic(ref: Migrate all packages to openssl3 and python 3.11 #5820 (comment) and sabnzbd not starting after upgrade sabnzbd to version 4.0.2-62 and Python to version 3.11.4-6 on my NAS DS212+ #5841)setuptoolsas issue withnunmpynow resolved [BUG] breaks numpy in cross-compiling environment pypa/setuptools#3549Checklist
all-supportedcompleted successfullyType of change