Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Button Component Missing Active State #173

Closed
shrix1 opened this issue May 8, 2024 · 2 comments 路 Fixed by #236
Closed

[BUG]: Button Component Missing Active State #173

shrix1 opened this issue May 8, 2024 · 2 comments 路 Fixed by #236
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@shrix1
Copy link
Contributor

shrix1 commented May 8, 2024

Description 馃摑

There is no active state on button component in sidebar : https://syntaxui.com/components/button/neubrutalism-button

Screenshot 2024-05-08 at 2 24 10鈥疨M

How to Fix:

Active state should look something like this:

Screenshot 2024-05-08 at 2 32 50鈥疨M

Link 馃敆

https://syntaxui.com/components/button/neubrutalism-button

@github-actions github-actions bot added the bug Something isn't working label May 8, 2024
@The-CodeINN
Copy link

The-CodeINN commented May 9, 2024

I think the pathname changes when you in a child page. What can be done is add the active state to the child pages

@epoll31
Copy link
Contributor

epoll31 commented May 9, 2024

This might be the intended functionality.

But, if we wanted to change it to include the subitems too, we can change Navigation.tsx:

let isActiveGroup = group.links.findIndex((link) => link.href === pathname) !== -1

This is how the current tab is selected, we can use includes instead of === or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants