Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added active state for sub-pages #236

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

epoll31
Copy link
Contributor

@epoll31 epoll31 commented Jun 20, 2024

Description

added active state for sub-pages

Related Issue

Fixes #173

Proposed Changes

  • added a new matchPath helper function to src/components/Navigation.tsx
  • using matchPath instead of link.href === pathname throughout file

Screenshots

Screenshot 2024-06-20 at 10 25 24 AM

Checklist

Please check the boxes that apply:

  • I have rebased my branch on top of the latest main branch.
  • I have tested the changes locally
  • I ran npm run build and build is successful
  • I have added necessary documentation (if applicable)
  • I have updated the credits.md file (if applicable)

Additional Context

Please provide any additional context or information about the pull request here.

@epoll31 epoll31 requested a review from Ansub as a code owner June 20, 2024 17:26
Copy link

vercel bot commented Jun 20, 2024

@epoll31 is attempting to deploy a commit to the SyntaxUI Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
syntax-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 1:55pm

@Ansub Ansub merged commit e4b044c into SyntaxUI:main Jun 21, 2024
2 of 3 checks passed
@Ansub
Copy link
Member

Ansub commented Jun 21, 2024

Casual @epoll31 W!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Button Component Missing Active State
2 participants