New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reloadData bug causing no refresh when content changes #12

Open

pws5068 wants to merge 1 commit into Synthetic:master from pws5068:master

pws5068 commented Jul 12, 2014

reloadData has a bug introduced in 7d91f78 which causes new content to not refresh

Steps to reproduce:

Display an SYPaginator with several pages of images
Alter the data source, such that -paginatorView:viewForPageAtIndex: will return new pages/content
Call [paginatorView reloadData]

Expected result

SYPaginator updates to display the new set of pages

Actual result

SYPaginator does not update. viewForPageAtIndex is not called

This PR bypasses that issue by allowing "non-public" calls to _setCurrentPageIndex to request a content refresh. Feedback appreciated @dorshorst


          Fix reloadData bug causing no refresh when content changes

e0e566e

pws5068 mentioned this pull request

Calling ReloadData with fresh content doesn't update SYPaginator #14

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment