Cache rewards length (#1394)

Synthetixio · Jan 31, 2023 · 557e188 · 557e188
1 parent 5f09dbe
commit 557e188
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/protocol/synthetix/contracts/storage/Vault.sol b/protocol/synthetix/contracts/storage/Vault.sol
@@ -125,7 +125,9 @@ library Vault {
     ) internal returns (uint256[] memory, address[] memory) {
         uint256[] memory rewards = new uint256[](self.rewardIds.length());
         address[] memory distributors = new address[](self.rewardIds.length());
-        for (uint256 i = 0; i < self.rewardIds.length(); i++) {
+
+        uint numRewards = self.rewardIds.length();
+        for (uint256 i = 0; i < numRewards; i++) {
             RewardDistribution.Data storage dist = self.rewards[self.rewardIds.valueAt(i + 1)];
 
             if (address(dist.distributor) == address(0)) {