Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to notify the user about Proxy functions clashing #1481

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

mjlescano
Copy link
Member

No description provided.

README.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #1481 (874227b) into main (790342e) will decrease coverage by 1.06%.
The diff coverage is n/a.

❗ Current head 874227b differs from pull request most recent head 6182ced. Consider uploading reports for the commit 6182ced to get more accurate results

@@            Coverage Diff             @@
##             main    #1481      +/-   ##
==========================================
- Coverage   72.63%   71.57%   -1.06%     
==========================================
  Files          60       10      -50     
  Lines         771       95     -676     
  Branches      238       29     -209     
==========================================
- Hits          560       68     -492     
+ Misses        179       23     -156     
+ Partials       32        4      -28     
Flag Coverage Δ
core-contracts ?
core-modules 88.88% <ø> (ø)
core-utils ?
router 67.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...contracts/contracts/utils/SafeCast/SafeCastU56.sol
...cts/contracts/initializable/InitializableMixin.sol
utils/core-utils/src/utils/ast/comparator.ts
utils/core-contracts/contracts/proxy/UUPSProxy.sol
utils/core-utils/src/utils/hardhat/rpc.ts
utils/core-utils/src/utils/hardhat/contracts.ts
...ore-contracts/contracts/token/ERC721Enumerable.sol
utils/core-utils/src/utils/solidity/compiler.ts
utils/core-utils/src/utils/ast/storage-struct.ts
...contracts/contracts/utils/SafeCast/SafeCastU32.sol
... and 40 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mjlescano mjlescano merged commit 066e86c into main Mar 1, 2023
@mjlescano mjlescano deleted the update-proxy-validation branch March 1, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant