FEATURE: ElectionModule #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theethernaut
added this to the ELECTION 3: Fully functional first version of the ElectionModule milestone
Codecov Report
@@ Coverage Diff @@
## main #696 +/- ##
==========================================
+ Coverage 97.16% 97.24% +0.08%
==========================================
Files 71 77 +6
Lines 1233 1271 +38
Branches 62 98 +36
==========================================
+ Hits 1198 1236 +38
Misses 35 35
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* WIP ElectionModule init * Linter fixes * Fix * Linter fixes * ElectionModule reporting getEpochStatus() * Increase test coverage * ElectionSchedule modifiers * Comment unused modifiers * More ElectionModule status checks * Interoduce ElectionBase * Progress with ElectionModule period management * Simplified ElectionSchedule modifiers * Using IElectionModule * Fix * TIdy ups * Fix * Fix * Undo changes to InitError * Minor rename * Processing PR feedback * Renames * Implemented PR feedback * Better time checks * Linter fix
* Bootstrap sets functionality * Basic SetUtil tests * Implemented AddressSet
* WIP ElectionModule init * Linter fixes * Fix * Linter fixes * ElectionModule reporting getEpochStatus() * Increase test coverage * ElectionSchedule modifiers * Comment unused modifiers * More ElectionModule status checks * Interoduce ElectionBase * Progress with ElectionModule period management * Simplified ElectionSchedule modifiers * Using IElectionModule * Fix * TIdy ups * Fix * Fix * Undo changes to InitError * Minor rename * Processing PR feedback * Renames * Implemented PR feedback * Preparing feature * Implemented nominations
* WIP ElectionModule init * Linter fixes * Fix * Linter fixes * ElectionModule reporting getEpochStatus() * Increase test coverage * ElectionSchedule modifiers * Comment unused modifiers * More ElectionModule status checks * Interoduce ElectionBase * Progress with ElectionModule period management * Simplified ElectionSchedule modifiers * Using IElectionModule * Fix * TIdy ups * Fix * Fix * Undo changes to InitError * Minor rename * Processing PR feedback * Renames * Implemented PR feedback * Start voting ability * Added ElectionModule vote tests * WIP ability to vote * Update election tests * Tidy ups * Move check to save gas * Have a ballot with multiple candidates in tests * Lint fix
Merged
* WIP ElectionModule init * Linter fixes * Fix * Linter fixes * ElectionModule reporting getEpochStatus() * Increase test coverage * ElectionSchedule modifiers * Comment unused modifiers * More ElectionModule status checks * Interoduce ElectionBase * Progress with ElectionModule period management * Simplified ElectionSchedule modifiers * Using IElectionModule * Fix * TIdy ups * Fix * Fix * Undo changes to InitError * Minor rename * Processing PR feedback * Renames * Implemented PR feedback * Start voting ability * Added ElectionModule vote tests * WIP ability to vote * Update election tests * Tidy ups * Move check to save gas * Progress with dates review * WIP adjustEpoch refactor * Linter fixes * Cleanups * Fixes * Minor improvements * Refactor to always use dates
…re/election-module
* Update to latest feature branch * Minor tidy up * Fixes * WIP initializable implementation in ElectionModule * Disabling initializables checks until fixed * Add comments to fix * Commented out initialzable tests
…re/election-module
* Update to latest feature branch * Minor tidy up * Fixes * WIP initializable implementation in ElectionModule * Disabling initializables checks until fixed * Add comments to fix * Commented out initialzable tests * WIP * WIP * WIP * Basic evaluation working * Rename * Add tests * Linter fixes * Update packages/core-modules/contracts/submodules/election/ElectionTally.sol Co-authored-by: Matías Lescano <mjlescano@users.noreply.github.com> * Move logic that determines when election evaluation ends * More compact reversions * Update packages/core-modules/contracts/modules/ElectionModule.sol Co-authored-by: Leonardo Massazza <leo@synthetix.io> * Update packages/core-modules/contracts/modules/ElectionModule.sol Co-authored-by: Leonardo Massazza <leo@synthetix.io> * Update packages/core-modules/contracts/modules/ElectionModule.sol Co-authored-by: Leonardo Massazza <leo@synthetix.io> * Fix ballot counting algo Co-authored-by: Matías Lescano <mjlescano@users.noreply.github.com> Co-authored-by: Leonardo Massazza <leo@synthetix.io>
* check initializable modules only * fix tests
* Add ERC20HistoricalBalance * test skeleton * add block helper * fix tests
* Create council token * Contracts for create council token * Record first council members * Preparing for nft shuffle * WIP * Working NFTs * Renames * Update Solidity version * Minor tweaks * More minor tewaks * Addded comment
* Create council token * Contracts for create council token * Record first council members * Preparing for nft shuffle * WIP * Working NFTs * Renames * Update Solidity version * Minor tweaks * More minor tewaks * Fn renames in ElectionModule * Add tests * WIP events * Moar events * WIP even moar * VoteRecorded event * Election evaluation events * Election resolution events
* Create council token * Contracts for create council token * Record first council members * Preparing for nft shuffle * WIP * Working NFTs * Renames * Update Solidity version * Minor tweaks * More minor tewaks * Fn renames in ElectionModule * Add tests * Fix assertBn.eq( Co-authored-by: Matías <mjlescano@protonmail.com>
* Idea for more consistent election module storage * WIP cleanups * WIP cleanups * WIP tidy ups * WIP docs * More docs * Simplify ElectionSchedule * Move tests * Make some fns external * Rename fn * Linter fix * Update comments * More docs * Linter fixes * Move enum
…re/election-module
* Moved helper * Remove old helper * Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ElectionModule implementation feature branch.
Spec: https://hackmd.io/@wDuYijTaRY6GbPExcc1gWw/HkNyRskjK
Reference implementation: #632