Send rewards into l2 #818
Merged
Send rewards into l2 #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
19 tasks
i-stam
reviewed
Oct 30, 2020
| @@ -120,9 +141,28 @@ contract SynthetixBridgeToOptimism is Owned, MixinResolver, ISynthetixBridgeToOp | |||
| emit BridgeMigrated(address(this), newBridge, contractBalance); | |||
| } | |||
|
|
|||
| // invoked by RewardsDistribution on L1 (takes SNX) | |||
| function notifyRewardAmount(uint256 reward) external { | |||
There was a problem hiding this comment.
It seems that notifyRewardAmount() and rewardDeposit() can be combined and merged
# Conflicts: # package-lock.json
Codecov Report
@@ Coverage Diff @@
## develop #818 +/- ##
===========================================
- Coverage 98.40% 97.94% -0.47%
===========================================
Files 59 59
Lines 3954 3990 +36
Branches 513 514 +1
===========================================
+ Hits 3891 3908 +17
- Misses 63 82 +19
Continue to review full report at Codecov.
|
i-stam
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates
SynthetixBridgeToOptimismto use new smockit testing library