SIP 100 Resolver & cache improvements #951

jjgonecrypto · 2020-12-04T14:58:08Z

Replaces #904

Goals

To reduce the load on deploys - processing many setResolverAndSyncCache calls is simply not scalable.
To minimize the use of superuser owner functionality
To reduce deployment sizes of contracts by reducing constructor logic (in particular for the OVM deployment of contracts)

Solidity Improvements

AddressResolver.importAddresses() emits an event AddressImported for each address added
AddressResolver.rebuildCaches is exposed (and non-protected), for ease-of use
MixinResolver no longer requires Owned. resolver is set once only on construction (with the expectation that ReadProxyAddressResolver will be used.
MixinResolver has a predicate view isResolverCached()
MixinResolver has a rebuildCache() function (publicly available) for the contract to rebuild its cache. This function also emits a CacheUpdated event for each item added to it's private cache. This replaces the onlyOwner function: setResolverAndSyncCache(address _resolver)
MixinResolver.requireAndGetAddress() uses abi.encodePacked for string concatenation and a simpler API.
MixinResolver no longer performs tasks in the constructor. Contracts using the mixin must implement the abstract resolverAddressesRequired function.
MixinSystemSettings now wraps MixinResolver and returns the default resolverAddressesRequired() containing FlexibleStorage

Deployment Improvements

AddressResolver.importAddresses is invoked with every contract within the Synthetix protocol

Stats

AddressResolver.importAddresses(all 140 local targets) takes approximately 3.5m gas
AddressResolver.rebuildCaches(47 targets - most of the synths) takes approximately 6.5m gas

Known Limitations

As before, the deploy script will skip any contract with a dependency that has a : inside it. This is for the OVM bridge contracts, and connect-bridge must be run

…nthetixio/synthetix into cache-validation-for-resolver-develop

…-validation-for-resolver-develop # Conflicts: # contracts/AddressResolver.sol # contracts/MintableSynthetix.sol # contracts/MixinResolver.sol # contracts/Synthetix.sol # package-lock.json # publish/releases.json # publish/src/commands/deploy.js

# Conflicts: # contracts/SynthetixBridgeToBase.sol # publish/releases.json # test/prod/Synthetix.prod.js

# Conflicts: # package-lock.json # publish/releases.json

…nthetixio/synthetix into cache-validation-for-resolver-develop

jacko125 · 2020-12-07T06:16:18Z

contracts/MixinResolver.sol

-        // otherwise, check everything
-        for (uint i = 0; i < resolverAddressesRequired.length; i++) {
-            bytes32 name = resolverAddressesRequired[i];
+    function isResolverCached() external view returns (bool) {


@justinjmoses Will the deploy script be able to use isResolverCached after a release / upgrade to make sure everything is correctly cached and updated?

jacko125

changes LGTM.

…resolver caches

* Sending rewards into L2 * Fixing broken parts * Unit tests * New unit tests * Adding coverage for migrate * Remove duplicate tests * Use smock to test L2 contracts (#820) * Remove MintableSynthetixMock.sol * Remove test:multi (implemented in external PR) * Remove secondary contract refs (#823) * New messenger interface (#825) * Add initial tests * Add loop for initializing the array * Add test for importVestingEntries() * Comment out expected data tests * Import new IRewardEscrowV2 interface * Fix SynthetixBridgeToOptimism unit tests * Fix SynthetixBridgeToBase unit tests * Add more tests * Use V2 suffix for rewardEscrow view function * Add RewardEscrowV2 for mocking * Minor fix * Adds a new script to connect l2 bridge (#894) * Adds a new script to connect l2 bridge * Bugfix on new command * Skip vsynth prod test (#895) * Adds a --clean-build flag to the build command (#896) * Fix lint pre-commit hook (#900) * Disable etherscan checks in CI (#897) * Skip vsynth prod test (#902) * Adds a few options to connect-bridge (#906) * Adds a few options to connect-bridge * Fix connect-bridge pks * Minor fix * Another minor fix * Fix * Logging more output * Fix * Fix * Fixing prod test for vSynth and verifying more rinkeby contracts in etherscan * remove aggregator feed for BCH prices (#905) * Prepublish step * 2.32.2-sip-95-remove-BCH-aggregator * Prepublish step * 2.32.3 * Develop - Merge master into develop (#911) * Address list renamed to address set and make adding elements idempotent. (#917) * Preparations for L2 Phase C deployment (#901) * Improved lint pre-commit hook (#918) * Build circleci config with Mustache (#883) * L2 Phase C Release (#919) * Prepublish step * 2.33.0-ovm * Updating versions for ovm * Add circleci paths to prettierignore for pretty-quick (#921) * Do not ignore dotfiles in js linter (#923) * reset iETH prices (#922) * reset iETH prices * update StakingRewardsiETH address and ABI * merge master into develop (#926) * reset iETH prices (#922) and update StakingRewardsiETH address and ABI Co-authored-by: Alejandro Santander <Palebluedot@gmail.com> Co-authored-by: justin j. moses <justinjmoses@gmail.com> Co-authored-by: Synthetix Team <team@synthetix.io> * Prepublish step * 2.33.1 * Added dockerhub authetication to circleci (#924) * Improved connect-bridge script (#928) * Use new rewardEscrowV2 * Modify burnForMigration() to return a strcut array * Use structs to avoid stack too deep errors * Use new interface * Use new importedVestingEntries() and fix unit tests * sip99 (#936) * Prepublish step * 2.33.2 * sip 98 double swing trade exchange fees (#935) * update calculation of exchangeFeeRate for swing trades from long <-> short synths without sUSD step * fix audit findings on missing exchangeFeeRate assignment and update Exchanger tests * release adhara 2.33.0 adhara (#939) * release adhara kovan 2.33.0 * release Exchanger 2.33.0 Adhara to mainnet * Prepublish step * 2.33.0 * Prepublish step * 2.34.0 * Version fix for master along with some fork fixes (#941) * Fixing versions * merge 2.34.0 release into develop (#940) * Add 0-debt requirement for withdrawals (#942) * update migrateAccountEscrowBalances * use escrowMigrationPending flag for accounts to only migrate once from old esccrow to new * add stub for vest() and _amountClaimable calcs * Deploy bug fix: adding synths (#920) * Deployed fix for SynthetixBridgeToBase (#945) * Prepublish step * 2.34.1-ovm * add create escrow entry function * reset iSynths (#946) * Prepublish step * 2.34.2 * add vest function for entryIDs[] and claimableAmount calculation * implement vest and getVestingQuantity view * Adding Shaula entry on releases * Prepublish step * 2.35.0-ovm * remove duplicate function * Disable coverage in ci until its fixed (#950) * update BaseRewardEscrow test and update events * update BaseRewardEscrowV2 test * add revert tests for appendVestingEntry * update tests and ratePerSecond calculation * add approve snx for creating reward * SIP 100 Resolver & cache improvements (#951) * add quantity > duration test * add tests for ratePerSecond * add deltaOf public function and tests. Test failing as deltaOf is failing * Adding a new command to deploy an ovm instance pair for testing * Minor lint fix * Progress detecting unsafe deployments * More robust OVM safety checks * First OVM local deploy * Working * refactor deltaOf to timeSinceLastVested and update claimableAmount * remove only * update now -> block.timestamp and add tests for approve and create esrow entry * add stub test cases in BaseRewardEscrow * Return the right messenger addresses * Predict deploy addresses in L2 deploys * Tidier output in connect-bridge * Remove log * Add new logic and fix tests * Use alt key * update TODO require()'s for account merging * fix vest function loop * add vesting tests * fix getVestingQuantity view iteration and add vesting tests * Refactoring L2 prod tests * Update interfaces * Deposits working in L2 tests * Progress with L2 withdrawal tests * Linter fixes * Withdrawals working in L2 prod tests * Refactor depositAndMigrateEscrow() and add unit tests * Add extra safety checks * Use new addressResolver * Deploy RewardEscrowV2 on local and local-ovm * add smockit for issuer and issuer() contract for debtBalanceOf to BaseRewardEscrowV2 * update IRewardEscrowV2 interface and BaseRewardEscrow tests to smock * update smockit and mocking SNX token for vesting * remove unused var * update BaseRewardEscrowV2 tests with new MixinResolver * add NominateAccountToMerge event and test * add tests to vesting schedule merging fix lint Co-authored-by: justin j. moses <justinjmoses@gmail.com> Co-authored-by: i-stam <i.stamelakos@gmail.com> Co-authored-by: Alejandro Santander <Palebluedot@gmail.com> Co-authored-by: Synthetix Team <team@synthetix.io> Co-authored-by: Anton Jurisevic <zyzek@users.noreply.github.com> Co-authored-by: Clinton Ennis <clinton@synthetix.io> Co-authored-by: justin j. moses <justin@synthetix.io>

* Sending rewards into L2 * Fixing broken parts * Unit tests * New unit tests * Adding coverage for migrate * Remove duplicate tests * Use smock to test L2 contracts (#820) * Remove MintableSynthetixMock.sol * Remove test:multi (implemented in external PR) * Remove secondary contract refs (#823) * New messenger interface (#825) * Add initial tests * Add loop for initializing the array * Add test for importVestingEntries() * Comment out expected data tests * Import new IRewardEscrowV2 interface * Fix SynthetixBridgeToOptimism unit tests * Fix SynthetixBridgeToBase unit tests * Add more tests * Use V2 suffix for rewardEscrow view function * Add RewardEscrowV2 for mocking * Minor fix * Adds a new script to connect l2 bridge (#894) * Adds a new script to connect l2 bridge * Bugfix on new command * Skip vsynth prod test (#895) * Adds a --clean-build flag to the build command (#896) * Fix lint pre-commit hook (#900) * Disable etherscan checks in CI (#897) * Skip vsynth prod test (#902) * Adds a few options to connect-bridge (#906) * Adds a few options to connect-bridge * Fix connect-bridge pks * Minor fix * Another minor fix * Fix * Logging more output * Fix * Fix * Fixing prod test for vSynth and verifying more rinkeby contracts in etherscan * remove aggregator feed for BCH prices (#905) * Prepublish step * 2.32.2-sip-95-remove-BCH-aggregator * Prepublish step * 2.32.3 * Develop - Merge master into develop (#911) * Address list renamed to address set and make adding elements idempotent. (#917) * Preparations for L2 Phase C deployment (#901) * Improved lint pre-commit hook (#918) * Build circleci config with Mustache (#883) * L2 Phase C Release (#919) * Prepublish step * 2.33.0-ovm * Updating versions for ovm * Add circleci paths to prettierignore for pretty-quick (#921) * Do not ignore dotfiles in js linter (#923) * reset iETH prices (#922) * reset iETH prices * update StakingRewardsiETH address and ABI * merge master into develop (#926) * reset iETH prices (#922) and update StakingRewardsiETH address and ABI Co-authored-by: Alejandro Santander <Palebluedot@gmail.com> Co-authored-by: justin j. moses <justinjmoses@gmail.com> Co-authored-by: Synthetix Team <team@synthetix.io> * Prepublish step * 2.33.1 * Added dockerhub authetication to circleci (#924) * Improved connect-bridge script (#928) * Use new rewardEscrowV2 * Modify burnForMigration() to return a strcut array * Use structs to avoid stack too deep errors * Use new interface * Use new importedVestingEntries() and fix unit tests * sip99 (#936) * Prepublish step * 2.33.2 * sip 98 double swing trade exchange fees (#935) * update calculation of exchangeFeeRate for swing trades from long <-> short synths without sUSD step * fix audit findings on missing exchangeFeeRate assignment and update Exchanger tests * release adhara 2.33.0 adhara (#939) * release adhara kovan 2.33.0 * release Exchanger 2.33.0 Adhara to mainnet * Prepublish step * 2.33.0 * Prepublish step * 2.34.0 * Version fix for master along with some fork fixes (#941) * Fixing versions * merge 2.34.0 release into develop (#940) * Add 0-debt requirement for withdrawals (#942) * update migrateAccountEscrowBalances * use escrowMigrationPending flag for accounts to only migrate once from old esccrow to new * add stub for vest() and _amountClaimable calcs * Deploy bug fix: adding synths (#920) * Deployed fix for SynthetixBridgeToBase (#945) * Prepublish step * 2.34.1-ovm * add create escrow entry function * reset iSynths (#946) * Prepublish step * 2.34.2 * add vest function for entryIDs[] and claimableAmount calculation * implement vest and getVestingQuantity view * Adding Shaula entry on releases * Prepublish step * 2.35.0-ovm * remove duplicate function * Disable coverage in ci until its fixed (#950) * update BaseRewardEscrow test and update events * update BaseRewardEscrowV2 test * add revert tests for appendVestingEntry * update tests and ratePerSecond calculation * add approve snx for creating reward * SIP 100 Resolver & cache improvements (#951) * add quantity > duration test * add tests for ratePerSecond * add deltaOf public function and tests. Test failing as deltaOf is failing * Adding a new command to deploy an ovm instance pair for testing * Minor lint fix * Progress detecting unsafe deployments * More robust OVM safety checks * First OVM local deploy * Working * refactor deltaOf to timeSinceLastVested and update claimableAmount * remove only * update now -> block.timestamp and add tests for approve and create esrow entry * add stub test cases in BaseRewardEscrow * Return the right messenger addresses * Predict deploy addresses in L2 deploys * Tidier output in connect-bridge * Remove log * Add new logic and fix tests * Use alt key * update TODO require()'s for account merging * fix vest function loop * add vesting tests * fix getVestingQuantity view iteration and add vesting tests * Refactoring L2 prod tests * Update interfaces * Deposits working in L2 tests * Progress with L2 withdrawal tests * Linter fixes * Withdrawals working in L2 prod tests * Refactor depositAndMigrateEscrow() and add unit tests * Add extra safety checks * Use new addressResolver * Deploy RewardEscrowV2 on local and local-ovm * add smockit for issuer and issuer() contract for debtBalanceOf to BaseRewardEscrowV2 * update IRewardEscrowV2 interface and BaseRewardEscrow tests to smock * update smockit and mocking SNX token for vesting * remove unused var * update BaseRewardEscrowV2 tests with new MixinResolver * add NominateAccountToMerge event and test * add tests to vesting schedule merging fix lint * Update FeePool to use RewardEsrowV2 and feepool.js tests Co-authored-by: justin j. moses <justinjmoses@gmail.com> Co-authored-by: i-stam <i.stamelakos@gmail.com> Co-authored-by: Alejandro Santander <Palebluedot@gmail.com> Co-authored-by: Synthetix Team <team@synthetix.io> Co-authored-by: Anton Jurisevic <zyzek@users.noreply.github.com> Co-authored-by: Clinton Ennis <clinton@synthetix.io> Co-authored-by: justin j. moses <justin@synthetix.io>

* Sending rewards into L2 * Fixing broken parts * Unit tests * New unit tests * Adding coverage for migrate * Remove duplicate tests * Use smock to test L2 contracts (#820) * Remove MintableSynthetixMock.sol * Remove test:multi (implemented in external PR) * Remove secondary contract refs (#823) * New messenger interface (#825) * Add initial tests * Add loop for initializing the array * Add test for importVestingEntries() * Comment out expected data tests * Import new IRewardEscrowV2 interface * Fix SynthetixBridgeToOptimism unit tests * Fix SynthetixBridgeToBase unit tests * Add more tests * Use V2 suffix for rewardEscrow view function * Add RewardEscrowV2 for mocking * Minor fix * Adds a new script to connect l2 bridge (#894) * Adds a new script to connect l2 bridge * Bugfix on new command * Skip vsynth prod test (#895) * Adds a --clean-build flag to the build command (#896) * Fix lint pre-commit hook (#900) * Disable etherscan checks in CI (#897) * Skip vsynth prod test (#902) * Adds a few options to connect-bridge (#906) * Adds a few options to connect-bridge * Fix connect-bridge pks * Minor fix * Another minor fix * Fix * Logging more output * Fix * Fix * Fixing prod test for vSynth and verifying more rinkeby contracts in etherscan * remove aggregator feed for BCH prices (#905) * Prepublish step * 2.32.2-sip-95-remove-BCH-aggregator * Prepublish step * 2.32.3 * Develop - Merge master into develop (#911) * Address list renamed to address set and make adding elements idempotent. (#917) * Preparations for L2 Phase C deployment (#901) * Improved lint pre-commit hook (#918) * Build circleci config with Mustache (#883) * L2 Phase C Release (#919) * Prepublish step * 2.33.0-ovm * Updating versions for ovm * Add circleci paths to prettierignore for pretty-quick (#921) * Do not ignore dotfiles in js linter (#923) * reset iETH prices (#922) * reset iETH prices * update StakingRewardsiETH address and ABI * merge master into develop (#926) * reset iETH prices (#922) and update StakingRewardsiETH address and ABI Co-authored-by: Alejandro Santander <Palebluedot@gmail.com> Co-authored-by: justin j. moses <justinjmoses@gmail.com> Co-authored-by: Synthetix Team <team@synthetix.io> * Prepublish step * 2.33.1 * Added dockerhub authetication to circleci (#924) * Improved connect-bridge script (#928) * Use new rewardEscrowV2 * Modify burnForMigration() to return a strcut array * Use structs to avoid stack too deep errors * Use new interface * Use new importedVestingEntries() and fix unit tests * sip99 (#936) * Prepublish step * 2.33.2 * sip 98 double swing trade exchange fees (#935) * update calculation of exchangeFeeRate for swing trades from long <-> short synths without sUSD step * fix audit findings on missing exchangeFeeRate assignment and update Exchanger tests * release adhara 2.33.0 adhara (#939) * release adhara kovan 2.33.0 * release Exchanger 2.33.0 Adhara to mainnet * Prepublish step * 2.33.0 * Prepublish step * 2.34.0 * Version fix for master along with some fork fixes (#941) * Fixing versions * merge 2.34.0 release into develop (#940) * Add 0-debt requirement for withdrawals (#942) * Deploy bug fix: adding synths (#920) * Deployed fix for SynthetixBridgeToBase (#945) * Prepublish step * 2.34.1-ovm * reset iSynths (#946) * Prepublish step * 2.34.2 * Adding Shaula entry on releases * Prepublish step * 2.35.0-ovm * Disable coverage in ci until its fixed (#950) * SIP 100 Resolver & cache improvements (#951) * Adding a new command to deploy an ovm instance pair for testing * Minor lint fix * Progress detecting unsafe deployments * More robust OVM safety checks * First OVM local deploy * Working * Return the right messenger addresses * Predict deploy addresses in L2 deploys * Tidier output in connect-bridge * Remove log * Add new logic and fix tests * Use alt key * Refactoring L2 prod tests * Update interfaces * Deposits working in L2 tests * Progress with L2 withdrawal tests * Linter fixes * Withdrawals working in L2 prod tests * Refactor depositAndMigrateEscrow() and add unit tests * Add extra safety checks * Use new addressResolver * Deploy RewardEscrowV2 on local and local-ovm * Connect-bridge command: Check if resolver needs imports and if bridge needs sync separately (#944) * Prevent withdrawals on a suspended L2 system (#949) * Prevent withdrawals on a suspended L2 system * Also mocking SystemStatus on MintableSynthetix tests Co-authored-by: justin j. moses <justin@synthetix.io> * Adds a command that deploys an OVM pair of instances on local chains (#954) * Adding a new command to deploy an ovm instance pair for testing * Minor lint fix * Progress detecting unsafe deployments * More robust OVM safety checks * First OVM local deploy * Working * Predict deploy addresses in L2 deploys * Tidier output in connect-bridge * Remove log * Renamed some L2 functions (#961) * New command: migrate-bridge (#925) * Linter fixes * Migrate bridge cmd uses getVersions * Get latest bridge version directly from deployments * Update to develop * Added SystemSettings.crossDomainMessageGasLimit (#962) * Added a system setting * Minor fixes * Added FlexibleStorage in L2 bridge unit tests * Updates deploy-ovm-pair cmd to latest optimism-integration (#964) * WIP: add initial deployment and tests * Update interface * Build ci * Comment out tests * Comment out test file Co-authored-by: justin j. moses <justinjmoses@gmail.com> Co-authored-by: Alejandro Santander <Palebluedot@gmail.com> Co-authored-by: Jackson <jackosmacko@gmail.com> Co-authored-by: Synthetix Team <team@synthetix.io> Co-authored-by: Anton Jurisevic <zyzek@users.noreply.github.com> Co-authored-by: Clinton Ennis <clinton@synthetix.io> Co-authored-by: justin j. moses <justin@synthetix.io>

* Adds a new script to connect l2 bridge (#894) * Adds a new script to connect l2 bridge * Bugfix on new command * Skip vsynth prod test (#895) * Adds a --clean-build flag to the build command (#896) * Fix lint pre-commit hook (#900) * Disable etherscan checks in CI (#897) * Skip vsynth prod test (#902) * Adds a few options to connect-bridge (#906) * Adds a few options to connect-bridge * Fix connect-bridge pks * Minor fix * Another minor fix * Fix * Logging more output * Fix * Fix * Fixing prod test for vSynth and verifying more rinkeby contracts in etherscan * remove aggregator feed for BCH prices (#905) * Prepublish step * 2.32.2-sip-95-remove-BCH-aggregator * Prepublish step * 2.32.3 * Develop - Merge master into develop (#911) * Address list renamed to address set and make adding elements idempotent. (#917) * Preparations for L2 Phase C deployment (#901) * Improved lint pre-commit hook (#918) * Build circleci config with Mustache (#883) * L2 Phase C Release (#919) * Prepublish step * 2.33.0-ovm * Updating versions for ovm * Add circleci paths to prettierignore for pretty-quick (#921) * Do not ignore dotfiles in js linter (#923) * reset iETH prices (#922) * reset iETH prices * update StakingRewardsiETH address and ABI * merge master into develop (#926) * reset iETH prices (#922) and update StakingRewardsiETH address and ABI Co-authored-by: Alejandro Santander <Palebluedot@gmail.com> Co-authored-by: justin j. moses <justinjmoses@gmail.com> Co-authored-by: Synthetix Team <team@synthetix.io> * Prepublish step * 2.33.1 * Added dockerhub authetication to circleci (#924) * Improved connect-bridge script (#928) * sip99 (#936) * Prepublish step * 2.33.2 * sip 98 double swing trade exchange fees (#935) * update calculation of exchangeFeeRate for swing trades from long <-> short synths without sUSD step * fix audit findings on missing exchangeFeeRate assignment and update Exchanger tests * release adhara 2.33.0 adhara (#939) * release adhara kovan 2.33.0 * release Exchanger 2.33.0 Adhara to mainnet * Prepublish step * 2.33.0 * Prepublish step * 2.34.0 * Version fix for master along with some fork fixes (#941) * Fixing versions * merge 2.34.0 release into develop (#940) * Add 0-debt requirement for withdrawals (#942) * Deploy bug fix: adding synths (#920) * Deployed fix for SynthetixBridgeToBase (#945) * Prepublish step * 2.34.1-ovm * reset iSynths (#946) * Prepublish step * 2.34.2 * Adding Shaula entry on releases * Prepublish step * 2.35.0-ovm * Disable coverage in ci until its fixed (#950) * SIP 100 Resolver & cache improvements (#951) * Connect-bridge command: Check if resolver needs imports and if bridge needs sync separately (#944) * Prevent withdrawals on a suspended L2 system (#949) * Prevent withdrawals on a suspended L2 system * Also mocking SystemStatus on MintableSynthetix tests Co-authored-by: justin j. moses <justin@synthetix.io> * Adds a command that deploys an OVM pair of instances on local chains (#954) * Adding a new command to deploy an ovm instance pair for testing * Minor lint fix * Progress detecting unsafe deployments * More robust OVM safety checks * First OVM local deploy * Working * Predict deploy addresses in L2 deploys * Tidier output in connect-bridge * Remove log * Renamed some L2 functions (#961) * New command: migrate-bridge (#925) * Linter fixes * Migrate bridge cmd uses getVersions * Get latest bridge version directly from deployments * Update to develop * Added SystemSettings.crossDomainMessageGasLimit (#962) * Added a system setting * Minor fixes * Added FlexibleStorage in L2 bridge unit tests * Updates deploy-ovm-pair cmd to latest optimism-integration (#964) Co-authored-by: Alejandro Santander <Palebluedot@gmail.com> Co-authored-by: justin j. moses <justinjmoses@gmail.com> Co-authored-by: Jackson <jackosmacko@gmail.com> Co-authored-by: Synthetix Team <team@synthetix.io> Co-authored-by: Anton Jurisevic <zyzek@users.noreply.github.com> Co-authored-by: Clinton Ennis <clinton@synthetix.io> Co-authored-by: justin j. moses <justin@synthetix.io>

jjgonecrypto and others added 30 commits November 15, 2020 17:36

Basic reworking of address resolver setup

ab70fc7

Removing MixinResolver reason param

29d413c

Removing setResolverAndSyncCache from setup

8d7fd80

invalidateCache => rebuildCache and fixing binary option market

d9411f6

Fixing tests partially for new rebuild

3823797

Working into publish test

093b46d

Ensure the rebuild is called after importing addresses

6e3eb8f

Improving cache mechanism

3c824a9

Fixing lint

9409ff4

Merge branch 'develop' into cache-validation-for-resolver

08510d8

Updating lock

1cea903

Merge branch 'develop' into cache-validation-for-resolver-develop

12bacf9

releases update - have importer do the cache rebuilding

e8856b8

Merge branch 'develop' into cache-validation-for-resolver-develop

bef288a

Fixing it up

ccdafd1

Merge branch 'cache-validation-for-resolver-develop' of github.com:Sy…

b974c33

…nthetixio/synthetix into cache-validation-for-resolver-develop

Newer WIP

d08a5d7

Rebuild lock

23c8c8a

Mechanism to not use constructors

2f658ff

Fixing contracts

e40c88c

Fixing issue with resolver requirements in mixin resolvers

d32801f

Merge branch 'develop' into cache-validation-for-resolver-develop

aa962dd

Updating lock

0fdc9e9

Removing only filter from prod test

67b2489

Splitting back into two parts again

76e6370

Fixing issue for partial deploys

59d5c5c

Fixing skips of OVM bridges in deploy script

5e9b640

Fixing tests to rebuild caches and check isResolverCached without input

9588c1c

Merge branch 'develop' into cache-validation-for-resolver-develop

ee27bbb

# Conflicts: # contracts/SynthetixBridgeToBase.sol # publish/releases.json # test/prod/Synthetix.prod.js

jjgonecrypto and others added 11 commits December 2, 2020 19:51

Fixing it up

b789bcd

Fixing Manager tests of BO

556b3bf

Fixing DebtCache tests

5b1af5f

Fixing coverage

5fdcdde

More fixes

1a597d0

Fixing remaining tests

d824665

Merge branch 'develop' into cache-validation-for-resolver-develop

316bf3b

# Conflicts: # package-lock.json # publish/releases.json

Fixing publish deploy issue

bcdff4c

Merge branch 'develop' into cache-validation-for-resolver-develop

a13ac9f

A more robust way of combining requirements

6567c9d

Merge branch 'cache-validation-for-resolver-develop' of github.com:Sy…

1c851bd

…nthetixio/synthetix into cache-validation-for-resolver-develop

jjgonecrypto mentioned this pull request Dec 4, 2020

SIP-100 Resolver & Cache Improvements #904

Closed

theethernaut self-requested a review December 4, 2020 15:12

theethernaut approved these changes Dec 4, 2020

View reviewed changes

jjgonecrypto and others added 7 commits December 4, 2020 10:36

Fix deploy for forking- ensure legacy contracts are updated

42a7c81

Supporting pattern matching in releases (#952)

5a9788f

Fixing deployments test validation

c2b7d45

More explicit super calls

0fe0aae

Fixing deployments check

7309f60

Fixing control of deployer logic for awaiting owner on import

2933ea4

Fixing issue on deploy

bbf3c86

jacko125 reviewed Dec 7, 2020

View reviewed changes

jacko125 approved these changes Dec 7, 2020

View reviewed changes

Allowing BinaryOptionMarketManager to rebuild both modern and legacy …

18c4f1c

…resolver caches

jjgonecrypto merged commit 83191da into develop Dec 8, 2020

jjgonecrypto deleted the sip-100-resolver-and-cache-master branch December 8, 2020 04:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SIP 100 Resolver & cache improvements #951

SIP 100 Resolver & cache improvements #951

jjgonecrypto commented Dec 4, 2020 •

edited

jacko125 Dec 7, 2020 •

edited

jjgonecrypto Dec 8, 2020

jacko125 left a comment

SIP 100 Resolver & cache improvements #951

SIP 100 Resolver & cache improvements #951

Conversation

jjgonecrypto commented Dec 4, 2020 • edited

jacko125 Dec 7, 2020 • edited

Choose a reason for hiding this comment

jjgonecrypto Dec 8, 2020

Choose a reason for hiding this comment

jacko125 left a comment

Choose a reason for hiding this comment

jjgonecrypto commented Dec 4, 2020 •

edited

jacko125 Dec 7, 2020 •

edited