Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIDI Takeover Pickup hanging #427

Closed
PaulFreund opened this issue Aug 24, 2023 · 2 comments
Closed

MIDI Takeover Pickup hanging #427

PaulFreund opened this issue Aug 24, 2023 · 2 comments
Labels
bug Something isn't working
Milestone
Release 1.0

Comments

@PaulFreund
Copy link
Collaborator

PaulFreund commented Aug 24, 2023 •
edited

Describe the Issue
If Pickup is selected for MIDI takeover mode the values from my external encoder is only picked up if changed very slowly and otherwise hangs.
Might originate in #170

Expected Behavior

I expect the value to not change until the current value is met and then always change

Deluge Version

OLED

Firmware Version

Built from release/1.0

Firmware Version in the file name or display: d3171eb

Steps to Reproduce the Issue

  1. Enable MIDI takeover mode in MIDI settings
  2. Open Clip and open value like Pan or OSC1 PW
  3. Hold learn and turn knob
  4. Turn the knob very fast over the current value and see that it only changes once
  5. Turn very slowly to see it change continusoly
@PaulFreund PaulFreund added the bug Something isn't working label Aug 24, 2023
@PaulFreund
Copy link
Collaborator Author

@seangoodvibes FYI

@m-m-adams m-m-adams added this to the Release 1.0 milestone Aug 24, 2023
@seangoodvibes seangoodvibes mentioned this issue Aug 28, 2023
Merged
PaulFreund added a commit that referenced this issue Aug 28, 2023
@PaulFreund
Merge pull request #461 from seangoodvibes/miditakeover/threshold-adj…
1480866 
…ustment-for-midi-knob-sync

[Ready for Review] MIDI Takeover Mode: Resolve issue #427 : Pickup Hanging
@soymonitus
Copy link
Contributor

This was fixed yesterday in referenced PR. Please close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Release 1.0
Development

No branches or pull requests
3 participants
@PaulFreund @soymonitus @m-m-adams