Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kit/alphanumeric Order Inconsistencies #97

Closed
ok-reza opened this issue Jun 24, 2023 · 1 comment
Closed

Kit/alphanumeric Order Inconsistencies #97

ok-reza opened this issue Jun 24, 2023 · 1 comment

Comments

@ok-reza
Copy link
Collaborator

ok-reza commented Jun 24, 2023

This is part of the pre-OLED to post-OLED firmware inconsistencies I've noticed after loading the open-source community firmware onto a 7-SEG display Deluge. (See #76, #98, #99, #100, #101)

Kit/alphanumeric order inconsistencies and crashes.

Video showing the problem: https://www.youtube.com/watch?v=iq0kG6glywE

  • The alphanumeric ordering seems to be changed
  1. Expected: A1, A2, A3, B1, B2, B3, C1, etc.
  2. Observed: A1, B1, C1, loops through a shortened list of kits, A2, B2, C2...inconsistent and unpredictable.
  • A crash can occur when messing with the improper order found in the community firmware.
  1. Certain kits aren't showing up at all, but can be revealed when scrolling backwards then forwards.
  2. Doing so enough times causes a crash.

Replicable on OLED?

It would be helpful to know if this issue persists on an OLED Deluge. I would suggest adding kits A1, A2, A3 through H1, H2, H3 yourself and sharing the behavior.

@ok-reza ok-reza changed the title Kit/alphanumeric order inconsistencies Kit/alphanumeric Order Inconsistencies Jun 24, 2023
rohanhill pushed a commit that referenced this issue Jun 29, 2023
…he complex note-name file ordering only happens in SampleBrowser, not the other Browsers.

And, moved some functions from Browser to LoadInstrumentPresetUI, since those ones can no longer be static anyway.
@litui
Copy link
Collaborator

litui commented Jun 30, 2023

Thanks for the push @rohanhill! Slight slap on the wrist due for not using a Pull Request 😉, but I appreciate your attention to these issues. 🙇‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants