Incorporate DrumKeyboardScreen from alter-alter fork #112
Conversation
|
Can you have a look at the merge conflicts here? |
|
Yeah, I'll have to figure out how to rebase this on the new folder structure |
fix InstrumentClipView recording Fixed Affect Entire button, improved rendering for drum pads improved select knob on dyumkeyboad Fixed DrumKeyboardScreen Fixed a crash issue when turning the horizontal encoder.
m-m-adams
force-pushed
the
drum_velocities
branch
from
faa3a85
to
d4020bb
Compare
clang format with dbt version clang format keyboard screen
m-m-adams
force-pushed
the
drum_velocities
branch
from
fa611ac
to
1698d97
Compare
|
Still using the core logic from alter-alter's fork, scrolling horizontally now rotates the drum view like before while vertical scrolling jumps by 4 (thus appearing to go vertically) Also removed the use of 1 as a magic number to indicate default velocity, replaced with a define outside of the 1-127 range of possible midi values to avoid future conflicts |
There was a problem hiding this comment.
Overall looks fine. A few style nits.
The use of uiNeedsRendering seems to be a little excessive; I suspect most of them are redundant/not needed but don't really have a great way to prove that. If you want to spend time removing them we could probably get a few hundred cycles back but it might not be worth doing if stellar_aria is about to redo all the UI code anyway.
To do -
limit horizontal scroll behaviour to only scroll to pads that have drums mappedbased on discussion on discord changed goal to add a separate vertical scroll and move the existing behaviour to horizontal scroll instead