-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linkerscript rework and global initializations - Attempt 2 #117
Linkerscript rework and global initializations - Attempt 2 #117
Conversation
This seems to work on the OLED as well, but I noticed one issue: In the global settings menu (shift-select), the last two menu items (the newly added Runtime Features, as well as Firmware version) are both blank. you can still scroll to them and open them, they just have no text. |
Firmware version string is something I'll be overriding with a preprocessor define in forthcoming DBT changes (so might not be immediately crucial?). Kinda weird for nothing to show there though. |
to be clear the firmware version inside the submenu does display just fine, it is just the text "firmware version" in the main settings menu which has gone missing. |
Despite the builds working completely fine over hardware debuggers, @litui found an issue where the alignment and positioning of certain linkerscript sections made it so the deluge would not boot when the firmware was written to the QSPI ROM.
This is and should only ever be an issue with the linkerscript, so at least now we know the root cause, (and honestly should never have to edit the thing again).
There seemed to be an issue with initialization order (from my panicked attempts at fixing things last night), but methodically updating blocks of code to match the breaking commit eventually revealed nothing, so that might have been an issue with the linkerscript as well.
I've tested this on a 7seg Deluge with the bin on the SD card to replicate @litui's problems, and everything seems to be working well now.
Closes #113