Stereo Chorus

[alter-alter]

Added a stereo chorus effect to the MOD FXs

[litui]

@alter-alter heya! Thanks very much for the submission! I'll run workflows and see if we can get this tested and in soon =)

[litui]

Looks like just formatting failing. If you could give it a run with clang-format / clang-tidy 14.x that should take care of that.

What builds have been tested on the Deluge hardware so far?

[jamiefaye]

I did figure out where the Mod FX stuff was buried.

[m-m-adams]

Would it be possible to generalize this to add a second mod fx LFO at a slightly different rate and have it do stereo versions of all effects?

As is I think I hear phasing issues if I use the stereo chorus and then collapse to mono in a daw

[alter-alter]

What builds have been tested on the Deluge hardware so far?

I have tested the release-OLED build.

[alter-alter]

As is I think I hear phasing issues if I use the stereo chorus and then collapse to mono in a daw

I think phase problems are unlikely to occur because the pitch changes with the modulation of the delay time. (When the right channel rises in pitch, the left channel falls.)

[litui]

Congrats on the merge! We appreciate your contribution back to the community build.

[alter-alter]

Thanks!